archive/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-08-15 14:11:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

wifi: mac80211: fix WARN_ON for monitor mode on some devices

Browse source 
On devices without WANT_MONITOR_VIF (and probably without
channel context support) we get a WARN_ON for changing the
per-link setting of a monitor interface.

Since we already skip AP_VLAN interfaces and MONITOR with
WANT_MONITOR_VIF and/or NO_VIRTUAL_MONITOR should update
the settings, catch this in the link change code instead
of the warning.

Reported-by: Martin Kaistra <martin.kaistra@linutronix.de>
Link: https://lore.kernel.org/r/a9de62a0-28f1-4981-84df-253489da74ed@linutronix.de/
Fixes: c4382d5ca1 ("wifi: mac80211: update the right link for tx power")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Johannes Berg 2025-07-23 09:14:19 +02:00
parent 204bb85286
commit c57e5b9819
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
net/mac80211/main.c
View file

@ -408,9 +408,20 @@ void ieee80211_link_info_change_notify(struct ieee80211_sub_if_data *sdata,
WARN_ON_ONCE(changed & BSS_CHANGED_VIF_CFG_FLAGS);
if (!changed || sdata->vif.type == NL80211_IFTYPE_AP_VLAN)
if (!changed)
return;
switch (sdata->vif.type) {
case NL80211_IFTYPE_AP_VLAN:
return;
case NL80211_IFTYPE_MONITOR:
if (!ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF))
return;
break;
default:
break;
}
if (!check_sdata_in_driver(sdata))
return;