mirror of
https://github.com/torvalds/linux.git
synced 2025-08-15 14:11:42 +02:00
1bbdb81a98
The devlink_nl_rate_tc_bw_parse function uses a large stack array for
devlink attributes, which triggers a warning about excessive stack
usage:
net/devlink/rate.c: In function 'devlink_nl_rate_tc_bw_parse':
net/devlink/rate.c:382:1: error: the frame size of 1648 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]
Introduce a separate attribute set specifically for rate TC bandwidth
parsing that only contains the two attributes actually used: index
and bandwidth. This reduces the stack array from DEVLINK_ATTR_MAX
entries to just 2 entries, solving the stack usage issue.
Update devlink selftest to use the new 'index' and 'bw' attribute names
consistent with the YAML spec.
Example usage with ynl with the new spec:
./tools/net/ynl/cli.py --spec Documentation/netlink/specs/devlink.yaml \
--do rate-set --json '{
"bus-name": "pci",
"dev-name": "0000:08:00.0",
"port-index": 1,
"rate-tc-bws": [
{"index": 0, "bw": 50},
{"index": 1, "bw": 50},
{"index": 2, "bw": 0},
{"index": 3, "bw": 0},
{"index": 4, "bw": 0},
{"index": 5, "bw": 0},
{"index": 6, "bw": 0},
{"index": 7, "bw": 0}
]
}'
./tools/net/ynl/cli.py --spec Documentation/netlink/specs/devlink.yaml \
--do rate-get --json '{
"bus-name": "pci",
"dev-name": "0000:08:00.0",
"port-index": 1
}'
output for rate-get:
{'bus-name': 'pci',
'dev-name': '0000:08:00.0',
'port-index': 1,
'rate-tc-bws': [{'bw': 50, 'index': 0},
{'bw': 50, 'index': 1},
{'bw': 0, 'index': 2},
{'bw': 0, 'index': 3},
{'bw': 0, 'index': 4},
{'bw': 0, 'index': 5},
{'bw': 0, 'index': 6},
{'bw': 0, 'index': 7}],
'rate-tx-max': 0,
'rate-tx-priority': 0,
'rate-tx-share': 0,
'rate-tx-weight': 0,
'rate-type': 'leaf'}
Fixes: 566e8f108f ("devlink: Extend devlink rate API with traffic classes bandwidth management")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Closes: https://lore.kernel.org/netdev/20250708160652.1810573-1-arnd@kernel.org/
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507171943.W7DJcs6Y-lkp@intel.com/
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
Tested-by: Carolina Jubran <cjubran@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://patch.msgid.link/1753175609-330621-1-git-send-email-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
149 lines
7.7 KiB
C
149 lines
7.7 KiB
C
/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */
|
|
/* Do not edit directly, auto-generated from: */
|
|
/* Documentation/netlink/specs/devlink.yaml */
|
|
/* YNL-GEN kernel header */
|
|
|
|
#ifndef _LINUX_DEVLINK_GEN_H
|
|
#define _LINUX_DEVLINK_GEN_H
|
|
|
|
#include <net/netlink.h>
|
|
#include <net/genetlink.h>
|
|
|
|
#include <uapi/linux/devlink.h>
|
|
|
|
/* Common nested types */
|
|
extern const struct nla_policy devlink_dl_port_function_nl_policy[DEVLINK_PORT_FN_ATTR_CAPS + 1];
|
|
extern const struct nla_policy devlink_dl_rate_tc_bws_nl_policy[DEVLINK_RATE_TC_ATTR_BW + 1];
|
|
extern const struct nla_policy devlink_dl_selftest_id_nl_policy[DEVLINK_ATTR_SELFTEST_ID_FLASH + 1];
|
|
|
|
/* Ops table for devlink */
|
|
extern const struct genl_split_ops devlink_nl_ops[74];
|
|
|
|
int devlink_nl_pre_doit(const struct genl_split_ops *ops, struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_pre_doit_port(const struct genl_split_ops *ops,
|
|
struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_pre_doit_dev_lock(const struct genl_split_ops *ops,
|
|
struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_pre_doit_port_optional(const struct genl_split_ops *ops,
|
|
struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
void
|
|
devlink_nl_post_doit(const struct genl_split_ops *ops, struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
void
|
|
devlink_nl_post_doit_dev_lock(const struct genl_split_ops *ops,
|
|
struct sk_buff *skb, struct genl_info *info);
|
|
|
|
int devlink_nl_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb);
|
|
int devlink_nl_port_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_port_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_port_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_port_new_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_port_del_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_port_split_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_port_unsplit_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_sb_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_sb_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb);
|
|
int devlink_nl_sb_pool_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_sb_pool_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_sb_pool_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_sb_port_pool_get_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_sb_port_pool_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_sb_port_pool_set_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_sb_tc_pool_bind_get_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_sb_tc_pool_bind_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_sb_tc_pool_bind_set_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_sb_occ_snapshot_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_sb_occ_max_clear_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_eswitch_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_eswitch_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_dpipe_table_get_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_dpipe_entries_get_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_dpipe_headers_get_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_dpipe_table_counters_set_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_resource_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_resource_dump_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_reload_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_param_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_param_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_param_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_region_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_region_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_region_new_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_region_del_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_region_read_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_port_param_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_port_param_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_port_param_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_info_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_info_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_health_reporter_get_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_health_reporter_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_health_reporter_set_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_health_reporter_recover_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_health_reporter_diagnose_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_health_reporter_dump_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_health_reporter_dump_clear_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_flash_update_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_trap_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_trap_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_trap_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_trap_group_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_trap_group_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_trap_group_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_trap_policer_get_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_trap_policer_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_trap_policer_set_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_health_reporter_test_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
int devlink_nl_rate_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_rate_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_rate_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_rate_new_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_rate_del_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_linecard_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_linecard_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_linecard_set_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_selftests_get_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_selftests_get_dumpit(struct sk_buff *skb,
|
|
struct netlink_callback *cb);
|
|
int devlink_nl_selftests_run_doit(struct sk_buff *skb, struct genl_info *info);
|
|
int devlink_nl_notify_filter_set_doit(struct sk_buff *skb,
|
|
struct genl_info *info);
|
|
|
|
#endif /* _LINUX_DEVLINK_GEN_H */
|