mirror of
https://github.com/torvalds/linux.git
synced 2025-08-15 14:11:42 +02:00
2885daf470
Commitcac5cefbad("sched/smp: Make SMP unconditional") migrate_disable() even on UP builds. Commit06ddd17521("sched/smp: Always define is_percpu_thread() and scheduler_ipi()") made is_percpu_thread() check the affinity mask instead replying always true for UP mask. As a consequence smp_processor_id() now complains if invoked within a migrate_disable() section because is_percpu_thread() checks its mask and the migration check is left out. Make migration check unconditional of SMP. Fixes:cac5cefbad("sched/smp: Make SMP unconditional") Closes: https://lore.kernel.org/oe-lkp/202507100448.6b88d6f1-lkp@intel.com Reported-by: kernel test robot <oliver.sang@intel.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Chen Yu <yu.c.chen@intel.com> Link: https://lore.kernel.org/r/20250710082748.-DPO1rjO@linutronix.de
66 lines
1.3 KiB
C
66 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* lib/smp_processor_id.c
|
|
*
|
|
* DEBUG_PREEMPT variant of smp_processor_id().
|
|
*/
|
|
#include <linux/export.h>
|
|
#include <linux/kprobes.h>
|
|
#include <linux/sched.h>
|
|
|
|
noinstr static
|
|
unsigned int check_preemption_disabled(const char *what1, const char *what2)
|
|
{
|
|
int this_cpu = raw_smp_processor_id();
|
|
|
|
if (likely(preempt_count()))
|
|
goto out;
|
|
|
|
if (irqs_disabled())
|
|
goto out;
|
|
|
|
if (is_percpu_thread())
|
|
goto out;
|
|
|
|
if (current->migration_disabled)
|
|
goto out;
|
|
|
|
/*
|
|
* It is valid to assume CPU-locality during early bootup:
|
|
*/
|
|
if (system_state < SYSTEM_SCHEDULING)
|
|
goto out;
|
|
|
|
/*
|
|
* Avoid recursion:
|
|
*/
|
|
preempt_disable_notrace();
|
|
|
|
instrumentation_begin();
|
|
if (!printk_ratelimit())
|
|
goto out_enable;
|
|
|
|
printk(KERN_ERR "BUG: using %s%s() in preemptible [%08x] code: %s/%d\n",
|
|
what1, what2, preempt_count() - 1, current->comm, current->pid);
|
|
|
|
printk("caller is %pS\n", __builtin_return_address(0));
|
|
dump_stack();
|
|
|
|
out_enable:
|
|
instrumentation_end();
|
|
preempt_enable_no_resched_notrace();
|
|
out:
|
|
return this_cpu;
|
|
}
|
|
|
|
noinstr unsigned int debug_smp_processor_id(void)
|
|
{
|
|
return check_preemption_disabled("smp_processor_id", "");
|
|
}
|
|
EXPORT_SYMBOL(debug_smp_processor_id);
|
|
|
|
noinstr void __this_cpu_preempt_check(const char *op)
|
|
{
|
|
check_preemption_disabled("__this_cpu_", op);
|
|
}
|
|
EXPORT_SYMBOL(__this_cpu_preempt_check);
|