archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 21:58:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: remove deprecated error logging

Browse source 
common.error() is just deprecated util.error() renamed.
Remove calls to it and some other extraneous console logging
in tests.

PR-URL: https://github.com/nodejs/node/pull/3079
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Rich Trott 2015-09-26 15:00:51 -07:00
parent a334ddc467
commit 099cfbc58c
19 changed files with 2 additions and 135 deletions
Download patch file Download diff file Expand all files Collapse all files

25
test/parallel/test-net-binary.js
View file

@ -7,13 +7,6 @@ var binaryString = '';
for (var i = 255; i >= 0; i--) {
var s = '\'\\' + i.toString(8) + '\'';
var S = eval(s);
common.error(s +
' ' +
JSON.stringify(S) +
' ' +
JSON.stringify(String.fromCharCode(i)) +
' ' +
S.charCodeAt(0));
assert.ok(S.charCodeAt(0) == i);
assert.ok(S == String.fromCharCode(i));
binaryString += S;
@ -21,14 +14,11 @@ for (var i = 255; i >= 0; i--) {
// safe constructor
var echoServer = net.Server(function(connection) {
console.error('SERVER got connection');
connection.setEncoding('binary');
connection.on('data', function(chunk) {
common.error('SERVER recved: ' + JSON.stringify(chunk));
connection.write(chunk, 'binary');
});
connection.on('end', function() {
console.error('SERVER ending');
connection.end();
});
});
@ -37,7 +27,6 @@ echoServer.listen(common.PORT);
var recv = '';
echoServer.on('listening', function() {
console.error('SERVER listening');
var j = 0;
var c = net.createConnection({
port: common.PORT
@ -45,48 +34,34 @@ echoServer.on('listening', function() {
c.setEncoding('binary');
c.on('data', function(chunk) {
console.error('CLIENT data %j', chunk);
var n = j + chunk.length;
while (j < n && j < 256) {
common.error('CLIENT write ' + j);
c.write(String.fromCharCode(j), 'binary');
j++;
}
if (j === 256) {
console.error('CLIENT ending');
c.end();
}
recv += chunk;
});
c.on('connect', function() {
console.error('CLIENT connected, writing');
c.write(binaryString, 'binary');
});
c.on('close', function() {
console.error('CLIENT closed');
console.dir(recv);
echoServer.close();
});
c.on('finish', function() {
console.error('CLIENT finished');
});
});
process.on('exit', function() {
console.log('recv: ' + JSON.stringify(recv));
assert.equal(2 * 256, recv.length);
var a = recv.split('');
var first = a.slice(0, 256).reverse().join('');
console.log('first: ' + JSON.stringify(first));
var second = a.slice(256, 2 * 256).join('');
console.log('second: ' + JSON.stringify(second));
assert.equal(first, second);
});