From 1539f3b727a49fddd8b71eb6ea07aa3251d4afaf Mon Sep 17 00:00:00 2001 From: Levi Zim Date: Fri, 4 Jul 2025 20:56:56 +0800 Subject: [PATCH] deps: V8: cherry-pick 0ce2edb7adfd MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: Fix invalid template specialization Bug: chromium:40565911 Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420 Auto-Submit: Bruno Pitrus Commit-Queue: Jakob Linke Reviewed-by: Leszek Swirski Reviewed-by: Jakob Linke Cr-Commit-Position: refs/heads/main@{#99987} Refs: https://github.com/v8/v8/commit/0ce2edb7adfd65d4a2272098080980e88933786c Fixes: https://github.com/nodejs/node/issues/58485 PR-URL: https://github.com/nodejs/node/pull/58773 Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau --- common.gypi | 2 +- deps/v8/src/codegen/riscv/macro-assembler-riscv.h | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/common.gypi b/common.gypi index 3b70e9457fc..e89330a1045 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.15', + 'v8_embedder_string': '-node.16', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/codegen/riscv/macro-assembler-riscv.h b/deps/v8/src/codegen/riscv/macro-assembler-riscv.h index 35d1b9d4118..f2fecfc7628 100644 --- a/deps/v8/src/codegen/riscv/macro-assembler-riscv.h +++ b/deps/v8/src/codegen/riscv/macro-assembler-riscv.h @@ -406,10 +406,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public MacroAssemblerBase { push_helper(rs...); } - template <> - void push_helper(Register r) { - StoreWord(r, MemOperand(sp, 0)); - } + void push_helper() {} public: // Push a number of registers. The leftmost register first (to the highest @@ -554,10 +551,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public MacroAssemblerBase { LoadWord(r, MemOperand(sp, sizeof...(rs) * kSystemPointerSize)); } - template <> - void pop_helper(Register r) { - LoadWord(r, MemOperand(sp, 0)); - } + void pop_helper() {} public: // Pop a number of registers. The leftmost register last (from the highest