archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 21:58:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: common.expectsError should be a must call

Browse source 
Wrap expectsError in mustCall to make sure it's really called
as expected.

PR-URL: https://github.com/nodejs/node/pull/14088
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
Ruben Bridgewater 2017-07-05 15:04:24 +02:00 • committed by Refael Ackermann
parent be20e9ecfe
commit 1b2733f272
No known key found for this signature in database
GPG key ID: CD704BD80FDDDB64
18 changed files with 49 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/parallel/test-child-process-spawnsync-validation-errors.js
View file

@ -186,7 +186,7 @@ if (!common.isWindows) {
// Validate the killSignal option
const typeErr = /^TypeError: "killSignal" must be a string or number$/;
const unknownSignalErr =
common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL', type: TypeError });
common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL', type: TypeError }, 17);
pass('killSignal', undefined);
pass('killSignal', null);