lib: port errors to new system

This is a first batch of updates that touches non-underscored modules in
lib.

PR-URL: https://github.com/nodejs/node/pull/19034
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This commit is contained in:
Michaël Zasso 2018-02-27 14:55:32 +01:00
parent 023f49c5a9
commit 1e8d110e64
31 changed files with 377 additions and 418 deletions

View file

@ -8,10 +8,10 @@ let invalidArgTypeError;
if (common.isWindows) {
invalidArgTypeError =
common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 36);
common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 42);
} else {
invalidArgTypeError =
common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 56);
common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 62);
}
const invalidRangeError =
@ -127,18 +127,16 @@ if (!common.isWindows) {
{
// Validate the windowsHide option
const err = /^TypeError: "windowsHide" must be a boolean$/;
pass('windowsHide', undefined);
pass('windowsHide', null);
pass('windowsHide', true);
pass('windowsHide', false);
fail('windowsHide', 0, err);
fail('windowsHide', 1, err);
fail('windowsHide', __dirname, err);
fail('windowsHide', [], err);
fail('windowsHide', {}, err);
fail('windowsHide', common.mustNotCall(), err);
fail('windowsHide', 0, invalidArgTypeError);
fail('windowsHide', 1, invalidArgTypeError);
fail('windowsHide', __dirname, invalidArgTypeError);
fail('windowsHide', [], invalidArgTypeError);
fail('windowsHide', {}, invalidArgTypeError);
fail('windowsHide', common.mustNotCall(), invalidArgTypeError);
}
{