From 20c4b80ffca2738046b21f5792e239ccfa8c9321 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Sun, 4 May 2025 21:38:34 +0200 Subject: [PATCH] test: skip wasm-allocation tests for pointer compression builds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit V8 isolate group initialization forces allocation of the virtual memory cage with pointer compression builds and simply would not work when there is a smaller hard limit on the virtual memory. PR-URL: https://github.com/nodejs/node/pull/58171 Reviewed-By: Michaël Zasso Reviewed-By: Juan José Arboleda Reviewed-By: James M Snell --- test/wasm-allocation/wasm-allocation.status | 2 +- tools/test.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/test/wasm-allocation/wasm-allocation.status b/test/wasm-allocation/wasm-allocation.status index cf67fe9d67f..4663809cbd3 100644 --- a/test/wasm-allocation/wasm-allocation.status +++ b/test/wasm-allocation/wasm-allocation.status @@ -6,5 +6,5 @@ prefix wasm-allocation [true] # This section applies to all platforms -[$system!=linux || $asan==on] +[$system!=linux || $asan==on || $pointer_compression==on] test-wasm-allocation: SKIP diff --git a/tools/test.py b/tools/test.py index 08e10f18122..37afc975ca2 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1628,6 +1628,9 @@ def get_asan_state(vm, context): asan = Execute([vm, '-p', 'process.config.variables.asan'], context).stdout.strip() return "on" if asan == "1" else "off" +def get_pointer_compression_state(vm, context): + pointer_compression = Execute([vm, '-p', 'process.config.variables.v8_enable_pointer_compression'], context).stdout.strip() + return "on" if pointer_compression == "1" else "off" def Main(): parser = BuildOptions() @@ -1726,6 +1729,7 @@ def Main(): 'arch': vmArch, 'type': get_env_type(vm, options.type, context), 'asan': get_asan_state(vm, context), + 'pointer_compression': get_pointer_compression_state(vm, context), } test_list = root.ListTests([], path, context, arch, mode) unclassified_tests += test_list