archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 05:38:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tools: import rather than require ESLint plugins

Browse source 
Refs: https://github.com/nodejs/node/pull/57314
PR-URL: https://github.com/nodejs/node/pull/57315
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This commit is contained in:
Michaël Zasso 2025-03-07 15:52:52 +01:00 • committed by GitHub
parent 9325697379
commit 27f98c3cd1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 16 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

4
benchmark/eslint.config_partial.mjs
View file

@ -1,6 +1,4 @@
import { requireEslintTool } from '../tools/eslint/eslint.config_utils.mjs'; import { globals } from '../tools/eslint/eslint.config_utils.mjs';
const globals = requireEslintTool('globals');
export default [ export default [
{ {

4
doc/eslint.config_partial.mjs
View file

@ -1,14 +1,12 @@
import { import {
globals,
noRestrictedSyntaxCommonAll, noRestrictedSyntaxCommonAll,
noRestrictedSyntaxCommonLib, noRestrictedSyntaxCommonLib,
requireEslintTool,
} from '../tools/eslint/eslint.config_utils.mjs'; } from '../tools/eslint/eslint.config_utils.mjs';
import { builtinModules } from 'node:module'; import { builtinModules } from 'node:module';
const builtin = builtinModules.filter((name) => !name.startsWith('node:')); const builtin = builtinModules.filter((name) => !name.startsWith('node:'));
const globals = requireEslintTool('globals');
export default [ export default [
{ {
files: ['doc/**/*.md/*.{js,mjs,cjs}'], files: ['doc/**/*.md/*.{js,mjs,cjs}'],

12
eslint.config.mjs
View file

@ -7,20 +7,20 @@ import libConfig from './lib/eslint.config_partial.mjs';
import testConfig from './test/eslint.config_partial.mjs'; import testConfig from './test/eslint.config_partial.mjs';
import toolsConfig from './tools/eslint/eslint.config_partial.mjs'; import toolsConfig from './tools/eslint/eslint.config_partial.mjs';
import { import {
importEslintTool,
noRestrictedSyntaxCommonAll, noRestrictedSyntaxCommonAll,
noRestrictedSyntaxCommonLib, noRestrictedSyntaxCommonLib,
requireEslintTool,
resolveEslintTool, resolveEslintTool,
} from './tools/eslint/eslint.config_utils.mjs'; } from './tools/eslint/eslint.config_utils.mjs';
import nodeCore from './tools/eslint/eslint-plugin-node-core.js'; import nodeCore from './tools/eslint/eslint-plugin-node-core.js';
const js = requireEslintTool('@eslint/js'); const { default: js } = await importEslintTool('@eslint/js');
const babelEslintParser = requireEslintTool('@babel/eslint-parser'); const { default: babelEslintParser } = await importEslintTool('@babel/eslint-parser');
const babelPluginSyntaxImportAttributes = resolveEslintTool('@babel/plugin-syntax-import-attributes'); const babelPluginSyntaxImportAttributes = resolveEslintTool('@babel/plugin-syntax-import-attributes');
const babelPluginSyntaxImportSource = resolveEslintTool('@babel/plugin-syntax-import-source'); const babelPluginSyntaxImportSource = resolveEslintTool('@babel/plugin-syntax-import-source');
const jsdoc = requireEslintTool('eslint-plugin-jsdoc'); const { default: jsdoc } = await importEslintTool('eslint-plugin-jsdoc');
const markdown = requireEslintTool('eslint-plugin-markdown'); const { default: markdown } = await importEslintTool('eslint-plugin-markdown');
const stylisticJs = requireEslintTool('@stylistic/eslint-plugin-js'); const { default: stylisticJs } = await importEslintTool('@stylistic/eslint-plugin-js');
nodeCore.RULES_DIR = fileURLToPath(new URL('./tools/eslint-rules', import.meta.url)); nodeCore.RULES_DIR = fileURLToPath(new URL('./tools/eslint-rules', import.meta.url));

4
test/eslint.config_partial.mjs
View file

@ -1,12 +1,10 @@
/* eslint-disable @stylistic/js/max-len */ /* eslint-disable @stylistic/js/max-len */
import { import {
globals,
noRestrictedSyntaxCommonAll, noRestrictedSyntaxCommonAll,
requireEslintTool,
} from '../tools/eslint/eslint.config_utils.mjs'; } from '../tools/eslint/eslint.config_utils.mjs';
const globals = requireEslintTool('globals');
export default [ export default [
{ {
files: ['test/**/*.{js,mjs,cjs}'], files: ['test/**/*.{js,mjs,cjs}'],

4
tools/eslint/eslint.config_partial.mjs
View file

@ -1,6 +1,4 @@
import { requireEslintTool } from './eslint.config_utils.mjs'; import { globals } from './eslint.config_utils.mjs';
const globals = requireEslintTool('globals');
export default [ export default [
{ {

8
tools/eslint/eslint.config_utils.mjs
View file

@ -1,7 +1,11 @@
import { createRequire } from 'node:module'; import { createRequire } from 'node:module';
export const requireEslintTool = createRequire(new URL(import.meta.url)); export { default as globals } from 'globals';
export const resolveEslintTool = (request) => requireEslintTool.resolve(request);
export const importEslintTool = (specifier) => import(specifier);
const localRequire = createRequire(new URL(import.meta.url));
export const resolveEslintTool = (request) => localRequire.resolve(request);
export const noRestrictedSyntaxCommonAll = [ export const noRestrictedSyntaxCommonAll = [
{ {