archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 21:58:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: use random ports where possible

Browse source 
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
This commit is contained in:
Brian White 2016-05-29 03:06:56 -04:00
parent 624734e640
commit 2bc7841d0f
No known key found for this signature in database
GPG key ID: 606D7358F94DA209
358 changed files with 1555 additions and 1517 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/parallel/test-http-status-code.js
View file

@ -1,5 +1,5 @@
'use strict';
var common = require('../common');
require('../common');
var assert = require('assert');
var http = require('http');
@ -18,7 +18,7 @@ var s = http.createServer(function(req, res) {
res.end('hello world\n');
});
s.listen(common.PORT, nextTest);
s.listen(0, nextTest);
function nextTest() {
@ -27,7 +27,7 @@ function nextTest() {
}
var test = tests[testIdx];
http.get({ port: common.PORT }, function(response) {
http.get({ port: s.address().port }, function(response) {
console.log('client: expected status: ' + test);
console.log('client: statusCode: ' + response.statusCode);
assert.equal(response.statusCode, test);