archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: use random ports where possible

Browse source 
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
This commit is contained in:
Brian White 2016-05-29 03:06:56 -04:00
parent 624734e640
commit 2bc7841d0f
No known key found for this signature in database
GPG key ID: 606D7358F94DA209
358 changed files with 1555 additions and 1517 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/parallel/test-http-url.parse-https.request.js
View file

@ -17,9 +17,6 @@ var httpsOptions = {
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
};
var testURL = url.parse('https://localhost:' + common.PORT);
testURL.rejectUnauthorized = false;
function check(request) {
// assert that I'm https
assert.ok(request.socket._secureEstablished);
@ -33,7 +30,10 @@ var server = https.createServer(httpsOptions, function(request, response) {
server.close();
});
server.listen(common.PORT, function() {
server.listen(0, function() {
var testURL = url.parse(`https://localhost:${this.address().port}`);
testURL.rejectUnauthorized = false;
// make the request
var clientRequest = https.request(testURL);
// since there is a little magic with the agent