archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-16 06:08:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: use random ports where possible

Browse source 
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
This commit is contained in:
Brian White 2016-05-29 03:06:56 -04:00
parent 624734e640
commit 2bc7841d0f
No known key found for this signature in database
GPG key ID: 606D7358F94DA209
358 changed files with 1555 additions and 1517 deletions
Download patch file Download diff file Expand all files Collapse all files

7
test/parallel/test-net-connect-buffer.js
View file

@ -1,9 +1,8 @@
'use strict';
var common = require('../common');
require('../common');
var assert = require('assert');
var net = require('net');
var tcpPort = common.PORT;
var dataWritten = false;
var connectHappened = false;
@ -30,12 +29,12 @@ var tcp = net.Server(function(s) {
});
});
tcp.listen(common.PORT, function() {
tcp.listen(0, function() {
var socket = net.Stream({ highWaterMark: 0 });
console.log('Connecting to socket ');
socket.connect(tcpPort, function() {
socket.connect(this.address().port, function() {
console.log('socket connected');
connectHappened = true;
});