archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

doc: update collaborator guide to reflect TSC changes

Browse source 
Ref: https://github.com/nodejs/TSC/pull/1350
PR-URL: https://github.com/nodejs/node/pull/47126
Refs: https://github.com/nodejs/TSC/pull/1350
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit is contained in:
Rich Trott 2023-03-16 11:00:31 -07:00 • committed by Node.js GitHub Bot
parent b351f12a85
commit 321387e2cb
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
doc/contributing/collaborator-guide.md
View file

@ -340,8 +340,8 @@ For undocumented APIs that are public, open a pull request documenting the API.
### Breaking changes
At least two TSC members must approve backward-incompatible changes to the
`main` branch.
At least two TSC voting members must approve backward-incompatible changes to
the `main` branch.
Examples of breaking changes include:
@ -411,7 +411,7 @@ possible to avoid confusion and typosquatting attacks.
For pull requests introducing new core modules:
* Allow at least one week for review.
* Land only after sign-off from at least two TSC members.
* Land only after sign-off from at least two TSC voting members.
* Land with a [Stability Index][] of Experimental. The module must remain
Experimental until a semver-major release.
@ -742,7 +742,7 @@ git push upstream main
### I made a mistake
* Ping a TSC member.
* Ping a TSC voting member.
* With `git`, there's a way to override remote trees by force pushing
(`git push -f`). This is generally forbidden as it creates conflicts in other
people's forks. It is permissible for simpler slip-ups such as typos in commit