mirror of
https://github.com/nodejs/node.git
synced 2025-08-15 21:58:48 +02:00
http: refactor headersTimeout and requestTimeout logic
PR-URL: https://github.com/nodejs/node/pull/41263 Fixes: https://github.com/nodejs/node/issues/33440 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit is contained in:
parent
9d6af7d1fe
commit
3caa2c1a00
33 changed files with 858 additions and 413 deletions
|
@ -0,0 +1,61 @@
|
|||
'use strict';
|
||||
|
||||
const common = require('../common');
|
||||
const assert = require('assert');
|
||||
const { createServer } = require('http');
|
||||
const { connect } = require('net');
|
||||
|
||||
// This test validates that the server returns 408
|
||||
// after server.headersTimeout if the client
|
||||
// pauses sending in the middle of a header.
|
||||
|
||||
let sendDelayedRequestHeaders;
|
||||
const headersTimeout = common.platformTimeout(1000);
|
||||
const server = createServer({
|
||||
headersTimeout,
|
||||
requestTimeout: 0,
|
||||
keepAliveTimeout: 0,
|
||||
connectionsCheckingInterval: common.platformTimeout(250),
|
||||
}, common.mustNotCall());
|
||||
server.on('connection', common.mustCall(() => {
|
||||
assert.strictEqual(typeof sendDelayedRequestHeaders, 'function');
|
||||
sendDelayedRequestHeaders();
|
||||
}));
|
||||
|
||||
assert.strictEqual(server.headersTimeout, headersTimeout);
|
||||
|
||||
// Check that timeout event is not triggered
|
||||
server.once('timeout', common.mustNotCall((socket) => {
|
||||
socket.destroy();
|
||||
}));
|
||||
|
||||
server.listen(0, common.mustCall(() => {
|
||||
const client = connect(server.address().port);
|
||||
let response = '';
|
||||
|
||||
client.on('data', common.mustCall((chunk) => {
|
||||
response += chunk.toString('utf-8');
|
||||
}));
|
||||
|
||||
const errOrEnd = common.mustSucceed(function(err) {
|
||||
assert.strictEqual(
|
||||
response,
|
||||
'HTTP/1.1 408 Request Timeout\r\nConnection: close\r\n\r\n'
|
||||
);
|
||||
server.close();
|
||||
});
|
||||
|
||||
client.on('end', errOrEnd);
|
||||
client.on('error', errOrEnd);
|
||||
|
||||
client.resume();
|
||||
client.write('GET / HTTP/1.1\r\n');
|
||||
client.write('Connection: close\r\n');
|
||||
client.write('X-CRASH: ');
|
||||
|
||||
sendDelayedRequestHeaders = common.mustCall(() => {
|
||||
setTimeout(() => {
|
||||
client.write('1234567890\r\n\r\n');
|
||||
}, common.platformTimeout(headersTimeout * 2)).unref();
|
||||
});
|
||||
}));
|
Loading…
Add table
Add a link
Reference in a new issue