archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-16 06:08:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

buffer: stricter isEncoding

Browse source 
Due to code consolidation in https://github.com/nodejs/node/pull/7207
the isEncoding function got less strict. This commit makes sure
isEncoding returns false for empty strings as before the consolidation.

PR-URL: https://github.com/nodejs/node/pull/18790
Refs: https://github.com/nodejs/node/pull/7207
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-02-15 03:26:17 +01:00
parent 341770fedf
commit 452eed956e
No known key found for this signature in database
GPG key ID: F07496B3EB3C1762
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/buffer.js
View file

@ -427,7 +427,7 @@ Buffer.compare = function compare(a, b) {
Buffer.isEncoding = function isEncoding(encoding) { Buffer.isEncoding = function isEncoding(encoding) {
return typeof encoding === 'string' && return typeof encoding === 'string' && encoding.length !== 0 &&
normalizeEncoding(encoding) !== undefined; normalizeEncoding(encoding) !== undefined;
}; };
Buffer[kIsEncodingSymbol] = Buffer.isEncoding; Buffer[kIsEncodingSymbol] = Buffer.isEncoding;