archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

src: mark realm leaf classes final

Browse source 
Since these classes use virtual methods extensively, adding `final`
should allow compilers to optimize accesses better.

PR-URL: https://github.com/nodejs/node/pull/59355
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit is contained in:
Anna Henningsen 2025-08-04 20:42:35 +02:00
parent 3f6f6db43f
commit 60a58f63a1
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/node_realm.h
View file

@ -209,7 +209,7 @@ class Realm : public MemoryRetainer {
CppgcWrapperList cppgc_wrapper_list_; CppgcWrapperList cppgc_wrapper_list_;
}; };
class PrincipalRealm : public Realm { class PrincipalRealm final : public Realm {
public: public:
PrincipalRealm(Environment* env, PrincipalRealm(Environment* env,
v8::Local<v8::Context> context, v8::Local<v8::Context> context,

2
src/node_shadow_realm.h
View file

@ -9,7 +9,7 @@
namespace node { namespace node {
namespace shadow_realm { namespace shadow_realm {
class ShadowRealm : public Realm { class ShadowRealm final : public Realm {
public: public:
static ShadowRealm* New(Environment* env); static ShadowRealm* New(Environment* env);