archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

deps: V8: backport 1d3362c55396

Browse source 
Original commit message:

    [float16array] Turn flag on by default

    Float16Array has shipped in blink since M135. It is unlikely it'll
    unship by now, so turn the flag on by default.

    Bug: 42203953
    Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8
    Reviewed-on: 6513988
    Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#100104}

Refs: 1d3362c553
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/58230
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/58064
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This commit is contained in:
Shu-yu Guo 2025-05-06 14:40:37 -07:00 • committed by Node.js GitHub Bot
parent 974773572e
commit 6d61175db0
4 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
common.gypi
View file

@ -38,7 +38,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.12',
##### V8 defaults for Node.js #####

8
deps/v8/src/flags/flag-definitions.h vendored
View file

@ -294,9 +294,7 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
// Features that are complete (but still behind the --harmony flag).
#define HARMONY_STAGED_BASE(V)
#define JAVASCRIPT_STAGED_FEATURES_BASE(V) \
V(js_float16array, \
"Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16")
#define JAVASCRIPT_STAGED_FEATURES_BASE(V)
#ifdef V8_INTL_SUPPORT
#define HARMONY_STAGED(V) \
@ -320,7 +318,9 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
V(js_atomics_pause, "Atomics.pause") \
V(js_error_iserror, "Error.isError") \
V(js_regexp_escape, "RegExp.escape") \
V(js_explicit_resource_management, "explicit resource management")
V(js_explicit_resource_management, "explicit resource management") \
V(js_float16array, \
"Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16")
#ifdef V8_INTL_SUPPORT
#define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)

5
deps/v8/src/init/bootstrapper.cc vendored
View file

@ -5210,6 +5210,11 @@ DirectHandle<JSFunction> Genesis::InstallTypedArray(
GetCorrespondingRabGsabElementsKind(elements_kind), 0);
rab_gsab_initial_map->SetConstructor(*result);
if (rab_gsab_initial_map_index == Context::RAB_GSAB_FLOAT16_ARRAY_MAP_INDEX &&
v8_flags.js_float16array) {
LOG(isolate(), MapDetails(*rab_gsab_initial_map));
}
native_context()->set(rab_gsab_initial_map_index, *rab_gsab_initial_map,
UPDATE_WRITE_BARRIER, kReleaseStore);
Map::SetPrototype(isolate(), rab_gsab_initial_map, prototype);

4
deps/v8/test/test262/test262.status vendored
View file

@ -2431,7 +2431,6 @@
'staging/sm/Temporal/PlainMonthDay/from-coptic': [FAIL],
'staging/sm/Temporal/PlainMonthDay/from-gregory': [FAIL],
'staging/sm/Temporal/PlainMonthDay/result-not-after-1972-dec-31': [FAIL],
'staging/sm/Math/f16round': [FAIL],
'staging/sm/RegExp/unicode-ignoreCase': [FAIL],
'staging/sm/String/string-code-point-upper-lower-mapping': [FAIL],
'staging/sm/String/string-upper-lower-mapping': [FAIL],
@ -2442,13 +2441,10 @@
'staging/sm/TypedArray/prototype-constructor-identity': [FAIL],
'staging/sm/TypedArray/set-detached-bigint': [FAIL],
'staging/sm/TypedArray/seal-and-freeze': [FAIL],
'staging/sm/TypedArray/sort-negative-nan': [FAIL],
'staging/sm/TypedArray/sort_small': [FAIL],
'staging/sm/TypedArray/test-integrity-level': [FAIL],
'staging/sm/TypedArray/test-integrity-level-detached': [FAIL],
'staging/sm/TypedArray/toReversed-detached': [FAIL],
'staging/sm/TypedArray/toSorted-detached': [FAIL],
'staging/sm/TypedArray/toString': [FAIL],
'staging/sm/TypedArray/with': [FAIL],
'staging/sm/TypedArray/with-detached': [FAIL],
}],