archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

cli: support ${pid} placeholder in --cpu-prof-name

Browse source 
PR-URL: https://github.com/nodejs/node/pull/59072
Fixes: https://github.com/nodejs/node/issues/57418
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Haram Jeong 2025-07-24 19:28:18 +09:00 • committed by GitHub
parent 38c2b926af
commit 7215d9b37f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 66 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

35
test/sequential/test-cpu-prof-name.js
View file

@ -8,6 +8,8 @@ const fixtures = require('../common/fixtures');
common.skipIfInspectorDisabled();
const assert = require('assert');
const fs = require('fs');
const path = require('path');
const { spawnSync } = require('child_process');
const tmpdir = require('../common/tmpdir');
@ -41,3 +43,36 @@ const {
assert.deepStrictEqual(profiles, [file]);
verifyFrames(output, file, 'fibonacci.js');
}
// --cpu-prof-name with ${pid} placeholder
{
tmpdir.refresh();
// eslint-disable-next-line no-template-curly-in-string
const profName = 'CPU.${pid}.cpuprofile';
const dir = tmpdir.path;
const output = spawnSync(process.execPath, [
'--cpu-prof',
'--cpu-prof-interval',
kCpuProfInterval,
'--cpu-prof-name',
profName,
fixtures.path('workload', 'fibonacci.js'),
], {
cwd: dir,
env
});
if (output.status !== 0) {
console.error(output.stderr.toString());
}
assert.strictEqual(output.status, 0);
const expectedFile = path.join(dir, `CPU.${output.pid}.cpuprofile`);
assert.ok(fs.existsSync(expectedFile), `Expected file ${expectedFile} not found.`);
verifyFrames(output, expectedFile, 'fibonacci.js');
fs.unlinkSync(expectedFile);
}