archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 21:58:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

test: add common.mustNotCall()

Browse source 
This commit adds a mustNotCall() helper for testing. This provides
an alternative to using common.fail() as a callback, or creating
a callback function for the sole purpose of calling common.fail().

PR-URL: https://github.com/nodejs/node/pull/11152
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This commit is contained in:
cjihrig 2017-02-03 14:54:19 -05:00
parent 9549329158
commit 7dd82dd1c3
124 changed files with 204 additions and 235 deletions
Download patch file Download diff file Expand all files Collapse all files

10
test/parallel/test-http-host-headers.js
View file

@ -38,7 +38,7 @@ function testHttp() {
host: 'localhost',
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', common.fail);
}, cb).on('error', common.mustNotCall());
http.request({
method: 'GET',
@ -46,7 +46,7 @@ function testHttp() {
host: 'localhost',
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', common.fail).end();
}, cb).on('error', common.mustNotCall()).end();
http.request({
method: 'POST',
@ -54,7 +54,7 @@ function testHttp() {
host: 'localhost',
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', common.fail).end();
}, cb).on('error', common.mustNotCall()).end();
http.request({
method: 'PUT',
@ -62,7 +62,7 @@ function testHttp() {
host: 'localhost',
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', common.fail).end();
}, cb).on('error', common.mustNotCall()).end();
http.request({
method: 'DELETE',
@ -70,6 +70,6 @@ function testHttp() {
host: 'localhost',
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', common.fail).end();
}, cb).on('error', common.mustNotCall()).end();
});
}