archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

lib: use <array>.push and <array>.unshift instead of <array>.concat

Browse source 
Using `push` and `unshift` methods is more performant than reassigning a
new array created with `concat`.

PR-URL: https://github.com/nodejs/node/pull/37239
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Antoine du Hamel 2021-02-05 16:17:57 +01:00
parent f392ac0bbe
commit 83cce8717f
3 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/_http_common.js
View file

@ -22,7 +22,7 @@
'use strict';
const {
ArrayPrototypeConcat,
ArrayPrototypePushApply,
MathMin,
Symbol,
RegExpPrototypeTest,
@ -66,7 +66,7 @@ function parserOnHeaders(headers, url) {
// Once we exceeded headers limit - stop collecting them
if (this.maxHeaderPairs <= 0 ||
this._headers.length < this.maxHeaderPairs) {
this._headers = ArrayPrototypeConcat(this._headers, headers);
ArrayPrototypePushApply(this._headers, headers);
}
this._url += url;
}