archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: update parallel/test-tls-dhe for OpenSSL 3.5

Browse source 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: https://github.com/nodejs/node/pull/57477
Refs: https://github.com/openssl/openssl/pull/26734
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Richard Lau 2025-03-17 03:42:55 +00:00
parent a0a69f5e4a
commit 91a771d3fe
No known key found for this signature in database
GPG key ID: C43CEC45C17AB93C
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
test/parallel/test-tls-dhe.js
View file

@ -72,7 +72,10 @@ function test(dhparam, keylen, expectedCipher) {
execFile(common.opensslCli, args, common.mustSucceed((stdout) => {
assert(keylen === null ||
stdout.includes(`Server Temp Key: DH, ${keylen} bits`));
// s_client < OpenSSL 3.5
stdout.includes(`Server Temp Key: DH, ${keylen} bits`) ||
// s_client >= OpenSSL 3.5
stdout.includes(`Peer Temp Key: DH, ${keylen} bits`));
assert(stdout.includes(`Cipher : ${expectedCipher}`));
server.close();
}));