benchmark: disambiguate filename and dirname read perf

PR-URL: https://github.com/nodejs/node/pull/58056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This commit is contained in:
Antoine du Hamel 2025-04-29 22:20:29 +02:00 committed by GitHub
parent 397802e9f6
commit 99c2c900d5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 16 additions and 9 deletions

View file

@ -1,32 +1,37 @@
'use strict'; 'use strict';
const path = require('path'); const path = require('path');
const { pathToFileURL, fileURLToPath } = require('url'); const { pathToFileURL } = require('url');
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const bench = common.createBenchmark(main, { const bench = common.createBenchmark(main, {
n: [1000], n: [1000],
valuesToRead: [
'dirname-and-filename',
'dirname',
'filename',
],
}); });
const file = pathToFileURL( const fixtureDir = path.resolve(__filename, '../../fixtures');
path.resolve(__filename, '../../fixtures/esm-dir-file.mjs'), const fixtureDirURL = pathToFileURL(fixtureDir);
); async function load(array, n, valuesToRead) {
async function load(array, n) {
for (let i = 0; i < n; i++) { for (let i = 0; i < n; i++) {
array[i] = await import(`${file}?i=${i}`); array[i] = await import(`${fixtureDirURL}/import-meta-${valuesToRead}.mjs?i=${i}`);
} }
return array; return array;
} }
function main({ n }) { function main({ n, valuesToRead }) {
const array = []; const array = [];
for (let i = 0; i < n; ++i) { for (let i = 0; i < n; ++i) {
array.push({ dirname: '', filename: '', i: 0 }); array.push({ dirname: '', filename: '', i: 0 });
} }
bench.start(); bench.start();
load(array, n).then((arr) => { load(array, n, valuesToRead).then((arr) => {
bench.end(n); bench.end(n);
assert.strictEqual(arr[n - 1].filename, fileURLToPath(file)); if (valuesToRead.includes('dirname')) assert.strictEqual(arr[n - 1].dirname, fixtureDir);
if (valuesToRead.includes('filename')) assert.strictEqual(arr[n - 1].filename, path.join(fixtureDir, `import-meta-${valuesToRead}.mjs`));
}); });
} }

View file

@ -0,0 +1 @@
export const dirname = import.meta.dirname;

View file

@ -0,0 +1 @@
export const filename = import.meta.filename;