archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

quic: update the guard to check openssl version

Browse source 
Since we need to be able to use the openssl adapter provided
by the ngtcp2 library, and because that adapter does not include
any compile guards to ensure that OpenSSL 3.5 is being used and
that the APIs are actually available, we need to add a compile
time check for the openssl version in order to conditionally
include the adapter to avoid build errors when using a shared
openssl library that is not OpenSSL 3.5.

Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/59249
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
James M Snell 2025-07-27 14:34:12 -07:00
parent ebfc28a037
commit 99c80e3a45
3 changed files with 92 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

31
deps/ngtcp2/ngtcp2.gyp vendored
View file

@ -129,6 +129,36 @@
'HAVE_NETINET_IN_H',
],
}],
# TODO: Support OpenSSL 3.5 shared library builds.
# The complexity here is that we need to use the ngtcp2 ossl
# adapter, which does not include any conditional checks to
# see if the version of OpenSSL used has the necessary QUIC
# APIs, so we need to ensure that we conditionally enable use
# of the adapter only when we know that the OpenSSL version we
# are compiling against has the necessary APIs. We can do that
# by checkig the OpenSSL version number but, currently, the
# code that does so checks only the VERSION.dat file that is
# bundled with the openssl dependency. We'll need to update
# that to support the shared library case, where the version
# of the shared library needs to be determined.
#
# TODO: Support Boringssl here also. ngtcp2 provides an adapter
# for Boringssl. If we can detect that boringssl is being used
# here then we can use that adapter and also set the
# QUIC_NGTCP2_USE_BORINGSSL define (the guard in quic/guard.h
# would need to be updated to check for this define).
['node_shared_openssl=="false" and openssl_version >= 0x3050001f', {
'sources': [
'<@(ngtcp2_sources_ossl)',
],
'direct_dependent_settings': {
'defines': [
# Tells us that we are using the OpenSSL 3.5 adapter
# that is provided by ngtcp2.
'QUIC_NGTCP2_USE_OPENSSL_3_5',
],
},
}]
],
'direct_dependent_settings': {
'defines': [
@ -143,7 +173,6 @@
},
'sources': [
'<@(ngtcp2_sources)',
'<@(ngtcp2_sources_ossl)',
]
},
{