archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 21:58:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

errors: improve ERR_INVALID_ARG_TYPE

Browse source 
ERR_INVALID_ARG_TYPE is the most common error used throughout the
code base. This improves the error message by providing more details
to the user and by indicating more precisely which values are allowed
ones and which ones are not.

It adds the actual input to the error message in case it's a primitive.
If it's a class instance, it'll print the class name instead of
"object" and "falsy" or similar entries are not named "type" anymore.

PR-URL: https://github.com/nodejs/node/pull/29675
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Ruben Bridgewater 2019-09-23 08:17:25 +02:00
parent fc28761d77
commit ac2fc0dd5f
No known key found for this signature in database
GPG key ID: F07496B3EB3C1762
127 changed files with 665 additions and 534 deletions
Download patch file Download diff file Expand all files Collapse all files

13
test/parallel/test-http2-server-shutdown-options-errors.js
View file

@ -19,13 +19,14 @@ server.on('stream', common.mustCall((stream) => {
const session = stream.session;
types.forEach((input) => {
const received = common.invalidArgTypeHelper(input);
common.expectsError(
() => session.goaway(input),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "code" argument must be of type number. Received type ' +
typeof input
message: 'The "code" argument must be of type number.' +
received
}
);
common.expectsError(
@ -33,8 +34,8 @@ server.on('stream', common.mustCall((stream) => {
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "lastStreamID" argument must be of type number. ' +
`Received type ${typeof input}`
message: 'The "lastStreamID" argument must be of type number.' +
received
}
);
common.expectsError(
@ -42,8 +43,8 @@ server.on('stream', common.mustCall((stream) => {
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "opaqueData" argument must be one of type Buffer, ' +
`TypedArray, or DataView. Received type ${typeof input}`
message: 'The "opaqueData" argument must be an instance of Buffer, ' +
`TypedArray, or DataView.${received}`
}
);
});