mirror of
https://github.com/nodejs/node.git
synced 2025-08-15 21:58:48 +02:00
http: improve parser error messages
Include the library-provided reason in the Error’s `message`. Fixes: https://github.com/nodejs/node/issues/28468 PR-URL: https://github.com/nodejs/node/pull/28487 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
parent
fd23c12263
commit
ba565a3734
8 changed files with 49 additions and 6 deletions
32
test/parallel/test-http-client-error-rawbytes.js
Normal file
32
test/parallel/test-http-client-error-rawbytes.js
Normal file
|
@ -0,0 +1,32 @@
|
|||
'use strict';
|
||||
const common = require('../common');
|
||||
const assert = require('assert');
|
||||
const http = require('http');
|
||||
const net = require('net');
|
||||
|
||||
const response = Buffer.from('HTTP/1.1 200 OK\r\n' +
|
||||
'Content-Length: 6\r\n' +
|
||||
'Transfer-Encoding: Chunked\r\n' +
|
||||
'\r\n' +
|
||||
'6\r\nfoobar' +
|
||||
'0\r\n');
|
||||
|
||||
const server = net.createServer(common.mustCall((conn) => {
|
||||
conn.write(response);
|
||||
}));
|
||||
|
||||
server.listen(0, common.mustCall(() => {
|
||||
const req = http.get(`http://localhost:${server.address().port}/`);
|
||||
req.end();
|
||||
req.on('error', common.mustCall((err) => {
|
||||
const reason = 'Content-Length can\'t be present with chunked encoding';
|
||||
assert.strictEqual(err.message, `Parse Error: ${reason}`);
|
||||
assert(err.bytesParsed < response.length);
|
||||
assert(err.bytesParsed >= response.indexOf('Transfer-Encoding'));
|
||||
assert.strictEqual(err.code, 'HPE_UNEXPECTED_CONTENT_LENGTH');
|
||||
assert.strictEqual(err.reason, reason);
|
||||
assert.deepStrictEqual(err.rawPacket, response);
|
||||
|
||||
server.close();
|
||||
}));
|
||||
}));
|
Loading…
Add table
Add a link
Reference in a new issue