archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-16 14:18:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: remove assert.doesNotThrow()

Browse source 
There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-02-09 02:32:04 +01:00
parent 4d3c3f039a
commit caee112e52
No known key found for this signature in database
GPG key ID: F07496B3EB3C1762
124 changed files with 598 additions and 1012 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/parallel/test-buffer-sharedarraybuffer.js
View file

@ -26,4 +26,4 @@ assert.deepStrictEqual(arr_buf, ar_buf);
assert.strictEqual(Buffer.byteLength(sab), sab.byteLength);
assert.doesNotThrow(() => Buffer.from({ buffer: sab }));
Buffer.from({ buffer: sab });