archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-16 06:08:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: remove assert.doesNotThrow()

Browse source 
There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-02-09 02:32:04 +01:00
parent 4d3c3f039a
commit caee112e52
No known key found for this signature in database
GPG key ID: F07496B3EB3C1762
124 changed files with 598 additions and 1012 deletions
Download patch file Download diff file Expand all files Collapse all files

5
test/parallel/test-console-async-write-error.js
View file

@ -2,7 +2,6 @@
const common = require('../common');
const { Console } = require('console');
const { Writable } = require('stream');
const assert = require('assert');
for (const method of ['dir', 'log', 'warn']) {
const out = new Writable({
@ -13,7 +12,5 @@ for (const method of ['dir', 'log', 'warn']) {
const c = new Console(out, out, true);
assert.doesNotThrow(() => {
c[method]('abc');
});
c[method]('abc');
}