archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: prepare test-crypto-rsa-dsa for newer OpenSSL

Browse source 
Update `parallel/test-crypto-rsa-dsa` to prepare for updating
`deps/openssl` to later versions of OpenSSL which support implicit
rejections with `RSA_PKCS1_PADDING`.

PR-URL: https://github.com/nodejs/node/pull/58100
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
Richard Lau 2025-05-01 15:50:23 +00:00 • committed by Node.js GitHub Bot
parent 0259df9faf
commit cb531b0616
1 changed files with 25 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

32
test/parallel/test-crypto-rsa-dsa.js
View file

@ -9,7 +9,7 @@ const crypto = require('crypto');
const constants = crypto.constants; const constants = crypto.constants;
const fixtures = require('../common/fixtures'); const fixtures = require('../common/fixtures');
const { hasOpenSSL3 } = require('../common/crypto'); const { hasOpenSSL, hasOpenSSL3 } = require('../common/crypto');
// Test certificates // Test certificates
const certPem = fixtures.readKey('rsa_cert.crt'); const certPem = fixtures.readKey('rsa_cert.crt');
@ -225,20 +225,38 @@ function test_rsa(padding, encryptOaepHash, decryptOaepHash) {
if (padding === constants.RSA_PKCS1_PADDING) { if (padding === constants.RSA_PKCS1_PADDING) {
if (!process.config.variables.node_shared_openssl) { if (!process.config.variables.node_shared_openssl) {
assert.throws(() => { // TODO(richardlau) remove check and else branch after deps/openssl
crypto.privateDecrypt({ // is upgraded.
if (hasOpenSSL(3, 2)) {
let decryptedBuffer = crypto.privateDecrypt({
key: rsaKeyPem, key: rsaKeyPem,
padding: padding, padding: padding,
oaepHash: decryptOaepHash oaepHash: decryptOaepHash
}, encryptedBuffer); }, encryptedBuffer);
}, { code: 'ERR_INVALID_ARG_VALUE' }); assert.deepStrictEqual(decryptedBuffer, input);
assert.throws(() => {
crypto.privateDecrypt({ decryptedBuffer = crypto.privateDecrypt({
key: rsaPkcs8KeyPem, key: rsaPkcs8KeyPem,
padding: padding, padding: padding,
oaepHash: decryptOaepHash oaepHash: decryptOaepHash
}, encryptedBuffer); }, encryptedBuffer);
}, { code: 'ERR_INVALID_ARG_VALUE' }); assert.deepStrictEqual(decryptedBuffer, input);
} else {
assert.throws(() => {
crypto.privateDecrypt({
key: rsaKeyPem,
padding: padding,
oaepHash: decryptOaepHash
}, encryptedBuffer);
}, { code: 'ERR_INVALID_ARG_VALUE' });
assert.throws(() => {
crypto.privateDecrypt({
key: rsaPkcs8KeyPem,
padding: padding,
oaepHash: decryptOaepHash
}, encryptedBuffer);
}, { code: 'ERR_INVALID_ARG_VALUE' });
}
} else { } else {
// The version of a linked against OpenSSL. May // The version of a linked against OpenSSL. May
// or may not support implicit rejection. Figuring // or may not support implicit rejection. Figuring