archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-16 06:08:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: skip wasm-allocation tests for pointer compression builds

Browse source 
V8 isolate group initialization forces allocation of the virtual
memory cage with pointer compression builds and simply would not
work when there is a smaller hard limit on the virtual memory.

PR-URL: https://github.com/nodejs/node/pull/58171
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Joyee Cheung 2025-05-04 21:38:34 +02:00 • committed by Antoine du Hamel
parent 3f954accb3
commit cccb15df7e
No known key found for this signature in database
GPG key ID: 21D900FFDB233756
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/wasm-allocation/wasm-allocation.status
View file

@ -6,5 +6,5 @@ prefix wasm-allocation
[true] # This section applies to all platforms
[$system!=linux || $asan==on]
[$system!=linux || $asan==on || $pointer_compression==on]
test-wasm-allocation: SKIP

4
tools/test.py
View file

@ -1619,6 +1619,9 @@ def get_asan_state(vm, context):
asan = Execute([vm, '-p', 'process.config.variables.asan'], context).stdout.strip()
return "on" if asan == "1" else "off"
def get_pointer_compression_state(vm, context):
pointer_compression = Execute([vm, '-p', 'process.config.variables.v8_enable_pointer_compression'], context).stdout.strip()
return "on" if pointer_compression == "1" else "off"
def Main():
parser = BuildOptions()
@ -1717,6 +1720,7 @@ def Main():
'arch': vmArch,
'type': get_env_type(vm, options.type, context),
'asan': get_asan_state(vm, context),
'pointer_compression': get_pointer_compression_state(vm, context),
}
test_list = root.ListTests([], path, context, arch, mode)
unclassified_tests += test_list