archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 05:38:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

src: warn about FastOneByteString invalidation

Browse source 
Minor warning about the use of FastOneByteString.

PR-URL: https://github.com/nodejs/node/pull/59275
Refs: https://github.com/cloudflare/workerd/pull/4625
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This commit is contained in:
James M Snell 2025-07-29 06:47:25 -07:00
parent c8b64bd023
commit cce8c4dd83
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/node_buffer.cc
View file

@ -1526,6 +1526,14 @@ uint32_t FastWriteString(Local<Value> receiver,
uint32_t max_length, uint32_t max_length,
// NOLINTNEXTLINE(runtime/references) // NOLINTNEXTLINE(runtime/references)
FastApiCallbackOptions& options) { FastApiCallbackOptions& options) {
// Just a heads up... this is a v8 fast api function. The use of
// FastOneByteString has some caveats. Specifically, a GC occurring
// between the time the FastOneByteString is created and the time
// we use it below can cause the FastOneByteString to become invalid
// and produce garbage data. This is not a problem here because we
// are not performing any allocations or other operations that would
// trigger a GC before the FastOneByteString is used. Take care when
// modifying this code to ensure that no operations would trigger a GC.
HandleScope handle_scope(options.isolate); HandleScope handle_scope(options.isolate);
SPREAD_BUFFER_ARG(dst_obj, dst); SPREAD_BUFFER_ARG(dst_obj, dst);
CHECK(offset <= dst_length); CHECK(offset <= dst_length);