archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-16 22:28:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: refactor async-hooks/test-httparser tests

Browse source 
CRLF variable was defined but only used on line 22 so the variable
was deleted and placed inside line 22 as a string literal. This
was in file test-httpparser.request.js

On line 46 there's a function declared that takes 3 arguments but
none of them are ever used so removed. This is in file
test-httpparser.response.js

PR-URL: https://github.com/nodejs/node/pull/14818
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Runite618 2017-08-13 20:23:20 +01:00 • committed by Tobias Nießen
parent 3f5d944ace
commit d4374ad651
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/async-hooks/test-httpparser.request.js
View file

@ -9,7 +9,6 @@ const { checkInvocations } = require('./hook-checks');
const binding = process.binding('http_parser');
const HTTPParser = binding.HTTPParser;
const CRLF = '\r\n';
const REQUEST = HTTPParser.REQUEST;
const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
@ -19,7 +18,7 @@ const hooks = initHooks();
hooks.enable();
const request = Buffer.from(
'GET /hello HTTP/1.1' + CRLF + CRLF
'GET /hello HTTP/1.1\r\n\r\n'
);
const parser = new HTTPParser(REQUEST);