mirror of
https://github.com/nodejs/node.git
synced 2025-08-15 21:58:48 +02:00
test: refactor common.expectsError
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
parent
e66c4deda8
commit
e038d6a1cd
396 changed files with 2118 additions and 2168 deletions
|
@ -62,7 +62,7 @@ server.listen(common.PIPE, common.mustCall(function() {
|
|||
server.close(common.expectsError({
|
||||
code: 'ERR_SERVER_NOT_RUNNING',
|
||||
message: 'Server is not running.',
|
||||
type: Error
|
||||
name: 'Error'
|
||||
}));
|
||||
}));
|
||||
}));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue