http: don't write error to socket

The state of the connection is unknown at this point and
writing to it can corrupt client state before it is aware
of an error.

PR-URL: https://github.com/nodejs/node/pull/34465
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Robert Nagy 2020-07-21 20:53:07 +02:00
parent de192246bc
commit e8d7fedf7c
3 changed files with 34 additions and 3 deletions

View file

@ -0,0 +1,31 @@
'use strict';
const { mustCall } = require('../common');
const assert = require('assert');
const { createServer } = require('http');
const { createConnection } = require('net');
const server = createServer();
server.on('request', mustCall((req, res) => {
res.write('asd', () => {
res.socket.emit('error', new Error('kaboom'));
});
}));
server.listen(0, mustCall(() => {
const c = createConnection(server.address().port);
let received = '';
c.on('connect', mustCall(() => {
c.write('GET /blah HTTP/1.1\r\n\r\n');
}));
c.on('data', mustCall((data) => {
received += data.toString();
}));
c.on('end', mustCall(() => {
// Should not include anything else after asd.
assert.strictEqual(received.indexOf('asd\r\n'), received.length - 5);
c.end();
}));
c.on('close', mustCall(() => server.close()));
}));