archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-16 22:28:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

src: do not reuse async resource in http parsers

Browse source 
Change resource being used, previously HTTParser was being reused.
We are now using IncomingMessage and ClientRequest objects.  The goal
here is to make the async resource unique for each async operatio

Refs: https://github.com/nodejs/node/pull/24330
Refs: https://github.com/nodejs/diagnostics/issues/248
Refs: https://github.com/nodejs/node/pull/21313

Co-authored-by: Matheus Marchini <mat@mmarchini.me>

PR-URL: https://github.com/nodejs/node/pull/25094
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Daniel Beckert 2018-12-13 15:35:48 -02:00 • committed by Matheus Marchini
parent 5aaf666b3b
commit ece507394a
No known key found for this signature in database
GPG key ID: BE516BA4874DB4D9
13 changed files with 102 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/async-hooks/test-httpparser.request.js
View file

@ -21,7 +21,7 @@ const request = Buffer.from(
);
const parser = new HTTPParser(REQUEST);
const as = hooks.activitiesOfTypes('HTTPPARSER');
const as = hooks.activitiesOfTypes('HTTPINCOMINGMESSAGE');
const httpparser = as[0];
assert.strictEqual(as.length, 1);
@ -47,7 +47,7 @@ process.on('exit', onexit);
function onexit() {
hooks.disable();
hooks.sanityCheck('HTTPPARSER');
hooks.sanityCheck('HTTPINCOMINGMESSAGE');
checkInvocations(httpparser, { init: 1, before: 1, after: 1, destroy: 1 },
'when process exits');
}