archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-17 22:58:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Revert "Remove 'connect' event from server side sockets"

Browse source 
Fixes #1276

This reverts commit f0a440d886.
This commit is contained in:
Ryan Dahl 2011-07-05 10:52:22 -07:00
parent e8542b6220
commit ede1acc1ed
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/net_legacy.js
View file

@ -955,6 +955,15 @@ function Server(/* [ options, ] listener */) {
DTRACE_NET_SERVER_CONNECTION(s); DTRACE_NET_SERVER_CONNECTION(s);
self.emit('connection', s); self.emit('connection', s);
// The 'connect' event probably should be removed for server-side
// sockets. It's redundant.
try {
s.emit('connect');
} catch (e) {
s.destroy(e);
return;
}
} }
}; };
} }

4
test/simple/test-net-reconnect.js
View file

@ -30,7 +30,9 @@ var client_recv_count = 0;
var disconnect_count = 0; var disconnect_count = 0;
var server = net.createServer(function(socket) { var server = net.createServer(function(socket) {
socket.write('hello\r\n'); socket.addListener('connect', function() {
socket.write('hello\r\n');
});
socket.addListener('end', function() { socket.addListener('end', function() {
socket.end(); socket.end();