archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

deps: V8: backport 493cb53691be

Browse source 
Original commit message:

    [include] suppress clang cast-function-type-mismatch warning on SetWeak

    Suppress clang warning cast-function-type-mismatch in embedder calls
    to `SetWeak`.

    Change-Id: I6c4eda1b932199a2ea4947fe851ffdf2ae04ad73
    Reviewed-on: 6689209
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net>
    Cr-Commit-Position: refs/heads/main@{#101186}

Ignore `cast-function-type` instead of `cast-function-type-mismatch` for
compatibility with older versions of Clang.

Refs: 493cb53691
PR-URL: https://github.com/nodejs/node/pull/59238
Refs: https://github.com/nodejs/node/issues/58069
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This commit is contained in:
Chengzhong Wu 2025-06-30 11:51:34 +01:00 • committed by Node.js GitHub Bot
parent 751203d36b
commit effe81f712
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
common.gypi
View file

@ -38,7 +38,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.16',
'v8_embedder_string': '-node.17',
##### V8 defaults for Node.js #####

7
deps/v8/include/v8-persistent-handle.h vendored
View file

@ -488,9 +488,16 @@ V8_INLINE void PersistentBase<T>::SetWeak(
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#if __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wcast-function-type"
#endif
api_internal::MakeWeak(this->slot(), parameter,
reinterpret_cast<Callback>(callback), type);
#if __clang__
#pragma clang diagnostic pop
#endif
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif