Commit graph

3 commits

Author SHA1 Message Date
Luigi Pinca
ba8fbf34f4
test: simplify test-http2-client-promisify-connect-error
There is no need to try to create a TCP connection that fails due to a
missing listening server. Also, the port used for the connection might
be used by another process when the connection is made.

PR-URL: https://github.com/nodejs/node/pull/57144
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2025-02-22 09:25:11 +00:00
Antoine du Hamel
8fc919d3cb
test: improve error output of test-http2-client-promisify-connect-error
PR-URL: https://github.com/nodejs/node/pull/57135
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-02-21 11:39:44 +00:00
ehsankhfr
42bce05ef6
http2: reject failed http2.connect when used with promisify
PR-URL: https://github.com/nodejs/node/pull/53475
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-06-20 14:48:27 +02:00