Robert Nagy
2aaa21f9f6
stream: pre-allocate _events
...
PR-URL: https://github.com/nodejs/node/pull/50428
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2023-10-29 16:29:59 +00:00
Joshua LeMay
65087c0486
test: migrate message v8 tests from Python to JS
...
PR-URL: https://github.com/nodejs/node/pull/50421
Fixes: https://github.com/nodejs/node/issues/47707
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
2023-10-29 05:55:01 +00:00
Jithil P Ponnan
14af167209
lib: align console.table row to the left
...
PR-URL: https://github.com/nodejs/node/pull/50135
Fixes: https://github.com/nodejs/node/issues/50117
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2023-10-28 01:14:22 +00:00
Khafra
e2cf2f0fda
src: readiterable entries may be empty
...
fixup
PR-URL: https://github.com/nodejs/node/pull/50398
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
2023-10-27 21:37:32 +00:00
Kerem Kat
8eea2d3709
test: fix crypto-dh error message for OpenSSL 3.x
...
OpenSSL 3.0.12 and 3.1.4 changes the type of error short keys and IVs
cause. The error message in test-crypto-dh for the "empty secret" is
now 'Supplied key is too small' instead of
'error:02800080:Diffie-Hellman routines::invalid secret'.
Error message change is test-only and uses the right error message for
versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series.
ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=0df40630850fb2740e6be6890bb905d3fc623b2d
ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=5f69f5c65e483928c4b28ed16af6e5742929f1ee
ref. https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363
PR-URL: https://github.com/nodejs/node/pull/50395
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-27 18:01:10 +00:00
Moshe Atlow
5fab505c76
test_runner: output errors of suites
...
PR-URL: https://github.com/nodejs/node/pull/50361
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2023-10-26 09:10:24 +00:00
Chengzhong Wu
4ddb263654
test: fix vm assertion actual and expected order
...
PR-URL: https://github.com/nodejs/node/pull/50371
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-26 07:46:21 +00:00
翠 / green
c41cf6fd49
fs: add stacktrace to fs/promises
...
Sync functions in fs throwed an error with a stacktrace which is helpful
for debugging. But functions in fs/promises throwed an error without
a stacktrace. This commit adds stacktraces by calling
Error.captureStacktrace and re-throwing the error.
Refs: https://github.com/nodejs/node/issues/34817
PR-URL: https://github.com/nodejs/node/pull/49849
Fixes: https://github.com/nodejs/node/issues/50160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2023-10-26 02:35:40 +00:00
Luke Albao
9c714d8232
test: v8: Add test-linux-perf-logger test suite
...
PR-URL: https://github.com/nodejs/node/pull/50352
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-25 23:37:54 +00:00
Joyee Cheung
c3a41d83de
src: implement structuredClone in native
...
Simplify the implementation by implementing it directly in C++.
This improves performance and also makes structuredClone supported
in custom snapshots.
PR-URL: https://github.com/nodejs/node/pull/50330
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
2023-10-25 17:45:11 +00:00
Robert Nagy
991fd9c255
stream: use Array for Readable buffer
...
PR-URL: https://github.com/nodejs/node/pull/50341
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2023-10-25 15:35:05 +00:00
Phil Nash
c60c11aae1
test_runner: adds built in lcov reporter
...
Fixes https://github.com/nodejs/node/issues/49626
PR-URL: https://github.com/nodejs/node/pull/50018
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2023-10-25 12:11:32 +00:00
Mika Fischer
4f5db8b26d
test_runner: test return value of mocked promisified timers
...
PR-URL: https://github.com/nodejs/node/pull/50331
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2023-10-25 07:15:55 +00:00
Richard Lau
2c4a332a9f
2023-10-24, Version 20.9.0 'Iron' (LTS)
...
Notable changes:
This release marks the transition of Node.js 20.x into Long Term Support (LTS)
with the codename 'Iron'. The 20.x release line now moves into "Active LTS"
and will remain so until October 2024. After that time, it will move into
"Maintenance" until end of life in April 2026.
PR-URL: https://github.com/nodejs/node/pull/50298
2023-10-24 10:12:56 -04:00
Robert Nagy
dbed0319ac
stream: refactor writable _write
...
PR-URL: https://github.com/nodejs/node/pull/50198
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2023-10-24 13:45:23 +00:00
Michael Dawson
abd8ff6f78
benchmark: skip test-benchmark-os on IBMi
...
- IBMi does not have the os.uptime implemented so skip
otherwise CI tests fail.
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-23 21:27:55 -04:00
Chengzhong Wu
52fcf14258
node-api: return napi_exception_pending on proxy handlers
...
Accessing JS objects can be trapped with proxy handlers. These
handlers can throw when no node-api errors occur. In such cases,
`napi_pending_exception` should be returned.
PR-URL: https://github.com/nodejs/node/pull/48607
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-10-23 18:17:49 -04:00
Moshe Atlow
41a3878f3d
test: improve watch mode test
...
PR-URL: https://github.com/nodejs/node/pull/50319
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2023-10-23 19:03:25 +00:00
Antoine du Hamel
8f742bb13f
test: ensure never settling promises are detected
...
PR-URL: https://github.com/nodejs/node/pull/50318
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-23 17:55:50 +00:00
Antoine du Hamel
2da66c1444
vm: use import attributes instead of import assertions
...
The old import assertions proposal has been
renamed to "import attributes" with the following major changes:
1. The keyword is now `with` instead of `assert`.
2. Unknown assertions cause an error rather than being ignored.
This PR updates the documentation to encourage folks to use the new
syntax, and add aliases to preserve backward compatibility.
PR-URL: https://github.com/nodejs/node/pull/50141
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-23 17:30:05 +00:00
Antoine du Hamel
08ae8401f1
esm: do not give wrong hints when detecting file format
...
PR-URL: https://github.com/nodejs/node/pull/50314
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2023-10-23 16:01:59 +00:00
Vinícius Lourenço
04f9385311
test: avoid v8 deadcode on performance function
...
PR-URL: https://github.com/nodejs/node/pull/50074
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-10-23 12:38:55 +00:00
Lucas Santos
45a0b153b3
test_runner: add Date to the supported mock APIs
...
signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/48638
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2023-10-23 11:23:12 +00:00
Juan José
c206b2a8a4
worker: handle detached MessagePort
from a different context
...
When `worker.moveMessagePortToContext` is used, the async handle
associated with the port, will be triggered more than needed (at least
one more time) and with null data. That can be avoided by simply
checking that the data is present and the port is not detached.
Fixes: https://github.com/nodejs/node/issues/49075
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/49150
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2023-10-22 21:20:52 +00:00
Aras Abbasi
a58ffad656
lib: improve performance of validateStringArray and validateBooleanArray
...
PR-URL: https://github.com/nodejs/node/pull/49756
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2023-10-22 21:12:38 +00:00
Yagiz Nizipli
d370ed0cd8
test: set test-watch-mode-inspect
as flaky
...
PR-URL: https://github.com/nodejs/node/pull/50259
Refs: https://github.com/nodejs/node/issues/49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-22 20:10:41 +00:00
Antoine du Hamel
745979cf39
Revert "test: set test-esm-loader-resolve-type
as flaky"
...
This reverts commit 2e4bb3c017
.
PR-URL: https://github.com/nodejs/node/pull/50315
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-21 15:54:28 +00:00
Niya Shiyas
4f0a7ae09a
test: replace forEach with for..of in test-http-perf_hooks.js
...
PR-URL: https://github.com/nodejs/node/pull/49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-21 16:21:50 +02:00
Niya Shiyas
b084b26c44
test: replace forEach with for..of in test-net-isipv4.js
...
PR-URL: https://github.com/nodejs/node/pull/49822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2023-10-21 12:32:43 +00:00
Antoine du Hamel
c38ba67a0d
test: deflake test-esm-loader-resolve-type
...
PR-URL: https://github.com/nodejs/node/pull/50273
Fixes: https://github.com/nodejs/node/issues/50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2023-10-21 09:25:11 +00:00
Niya Shiyas
63e9d0282d
test: replace forEach with for..of in test-http2-server
...
PR-URL: https://github.com/nodejs/node/pull/49819
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-21 07:01:01 +02:00
Niya Shiyas
fd562efcfe
test: replace forEach with for..of in test-http2-client-destroy.js
...
PR-URL: https://github.com/nodejs/node/pull/49820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-21 04:59:05 +00:00
Aras Abbasi
2e5ffe9fcf
util: remove internal mime fns from benchmarks
...
PR-URL: https://github.com/nodejs/node/pull/50201
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-21 02:12:44 +00:00
Yagiz Nizipli
6678a09b59
test: update url
web platform tests
...
PR-URL: https://github.com/nodejs/node/pull/50264
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-20 21:57:33 +00:00
Yagiz Nizipli
05a7810a1d
lib: add navigator.userAgent
...
PR-URL: https://github.com/nodejs/node/pull/50200
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-20 20:22:48 +00:00
Filip Skokan
cd6b86bb5a
crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey
...
PR-URL: https://github.com/nodejs/node/pull/50234
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2023-10-20 16:25:42 +00:00
Geoffrey Booth
02926d3c6a
esm: detect ESM syntax in ambiguous JavaScript
...
PR-URL: https://github.com/nodejs/node/pull/50096
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
2023-10-20 15:44:56 +00:00
Yagiz Nizipli
2d24518bfa
test: set test-emit-after-on-destroyed
as flaky
...
Ref: https://github.com/nodejs/node/issues/50245
PR-URL: https://github.com/nodejs/node/pull/50246
Refs: https://github.com/nodejs/node/issues/50245
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-10-20 15:36:06 +00:00
Yagiz Nizipli
35becbc9a9
test: set inspector async stack test as flaky
...
https://github.com/nodejs/node/issues/50243
PR-URL: https://github.com/nodejs/node/pull/50244
Refs: https://github.com/nodejs/node/issues/50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-10-20 10:27:50 -04:00
StefanStojanovic
b4cc3e27c7
test: set test-worker-nearheaplimit-deadlock flaky
...
PR-URL: https://github.com/nodejs/node/pull/50277
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-10-20 09:40:52 -04:00
Yagiz Nizipli
5ab70b3325
test: set test-cli-node-options
as flaky
...
PR-URL: https://github.com/nodejs/node/pull/50296
Refs: https://github.com/nodejs/node/issues/50295
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-10-20 09:28:36 -04:00
Michael Lumish
93c4efeb25
http2: allow streams to complete gracefully after goaway
...
A detailed analysis of the cause of this bug is in my linked comment on
the corresponding issue. The primary fix is the new setImmediate call in
Http2Stream#_destroy, which prevents a re-entrant call into
Http2Session::SendPendingData when sending trailers after the
Http2Session has been shut down, allowing the trailer data to be flushed
properly before the socket is closed.
As a result of this change, writes can be initiated later in the
lifetime of the Http2Session. So, when a JSStreamSocket is used as the
underlying socket reference for an Http2Session, it needs to be able to
accept write calls after it is closed.
In addition, now that outgoing data can be flushed differently after a
session is closed, in two tests clients receive errors that they
previously did not receive. I believe the new errors are more correct,
so I changed the tests to match.
Fixes: https://github.com/nodejs/node/issues/42713
Refs: https://github.com/nodejs/node/issues/42713#issuecomment-1756140062
PR-URL: https://github.com/nodejs/node/pull/50202
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-10-20 13:28:18 +00:00
Luigi Pinca
0345ea5928
test: reduce the number of requests and parsers
...
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.
Refs: https://github.com/nodejs/node/pull/50228#issuecomment-1768293624
PR-URL: https://github.com/nodejs/node/pull/50240
Fixes: https://github.com/nodejs/node/issues/49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-20 12:56:44 +00:00
Yagiz Nizipli
eed33c9dea
test: set crypto-timing test as flaky
...
PR-URL: https://github.com/nodejs/node/pull/50232
Refs: https://github.com/nodejs/node/issues/38226
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2023-10-20 02:15:13 +00:00
Yagiz Nizipli
f9c290f0e9
test: set test-structuredclone-*
as flaky
...
PR-URL: https://github.com/nodejs/node/pull/50261
Refs: https://github.com/nodejs/node/issues/50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
2023-10-19 16:03:49 +00:00
Antoine du Hamel
765339a32c
test: deflake test-loaders-workers-spawned
...
PR-URL: https://github.com/nodejs/node/pull/50251
Fixes: https://github.com/nodejs/node/issues/50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-19 10:44:46 +02:00
Jithil P Ponnan
a8af24b59c
test: improve code coverage of diagnostics_channel
...
test: improve code coverage of diagnostics_channel
PR-URL: https://github.com/nodejs/node/pull/50053
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2023-10-19 06:37:09 +00:00
Yagiz Nizipli
2e4bb3c017
test: set test-esm-loader-resolve-type
as flaky
...
Ref: https://github.com/nodejs/node/issues/50040
PR-URL: https://github.com/nodejs/node/pull/50226
Refs: https://github.com/nodejs/node/issues/50040
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
2023-10-19 00:15:28 +00:00
Yagiz Nizipli
e0bbe56630
test: set inspector async hook test as flaky
...
Ref: https://github.com/nodejs/node/issues/50222
PR-URL: https://github.com/nodejs/node/pull/50252
Refs: https://github.com/nodejs/node/issues/50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2023-10-18 22:19:39 +00:00
Tim Perry
dc04c5ed9a
tls: reduce TLS 'close' event listener warnings
...
Without this, some heavy usage of TLS sockets can result in
MaxListenersExceededWarning firing, from the 'this.on('close', ...)'
line here.
These appear to come from reinitializeHandle, which calls _wrapHandle
repeatedly on the same socket instance.
PR-URL: https://github.com/nodejs/node/pull/50136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2023-10-18 19:44:40 +00:00