Commit graph

3 commits

Author SHA1 Message Date
Luigi Pinca
19839f8d98 test: add semicolon after chunk size
The ABNF for chunk extensions as per RFC 7230 is

    chunk-ext      = *( ";" chunk-ext-name [ "=" chunk-ext-val ] )

    chunk-ext-name = token
    chunk-ext-val  = token / quoted-string

Add a semicolon after the chunk size for clarity.

This does not invalidate the test as it verifies that the HTTP parser
does not ignore chunk extensions.

PR-URL: https://github.com/nodejs/node/pull/40487
Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-11-06 07:36:30 +01:00
Luigi Pinca
13d43d63a4 test: fix test description
The request uses chunked transfer encoding and the HTTP response status
code is not 400 but 200.

PR-URL: https://github.com/nodejs/node/pull/40486
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-10-19 20:21:50 +02:00
Matteo Collina
2978b5a4a3
http: add regression test for chunked smuggling
PR-URL: https://github.com/nodejs-private/node-private/pull/284
Reviewed-By: Akshay K <iit.akshay@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
2021-10-12 15:40:03 +01:00