mirror of
https://github.com/nodejs/node.git
synced 2025-08-17 06:38:47 +02:00
53ac448022
As per the original pull request that introduced the OpenSSL version check in `parallel/test-crypto-dh`: ``` Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ``` Fix the check so that: - The older message is expected for OpenSSL 3.1.0. - The newer message is expected for OpenSSL from 3.1.4 (e.g. 3.2.x). Refs: https://github.com/nodejs/node/pull/50395 PR-URL: https://github.com/nodejs/node/pull/53503 Refs: https://github.com/nodejs/node/issues/53382 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
109 lines
3.6 KiB
JavaScript
109 lines
3.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const crypto = require('crypto');
|
|
|
|
{
|
|
const size = common.hasFipsCrypto || common.hasOpenSSL3 ? 1024 : 256;
|
|
const dh1 = crypto.createDiffieHellman(size);
|
|
const p1 = dh1.getPrime('buffer');
|
|
const dh2 = crypto.createDiffieHellman(p1, 'buffer');
|
|
const key1 = dh1.generateKeys();
|
|
const key2 = dh2.generateKeys('hex');
|
|
const secret1 = dh1.computeSecret(key2, 'hex', 'base64');
|
|
const secret2 = dh2.computeSecret(key1, 'latin1', 'buffer');
|
|
|
|
// Test Diffie-Hellman with two parties sharing a secret,
|
|
// using various encodings as we go along
|
|
assert.strictEqual(secret2.toString('base64'), secret1);
|
|
assert.strictEqual(dh1.verifyError, 0);
|
|
assert.strictEqual(dh2.verifyError, 0);
|
|
|
|
// Create "another dh1" using generated keys from dh1,
|
|
// and compute secret again
|
|
const dh3 = crypto.createDiffieHellman(p1, 'buffer');
|
|
const privkey1 = dh1.getPrivateKey();
|
|
dh3.setPublicKey(key1);
|
|
dh3.setPrivateKey(privkey1);
|
|
|
|
assert.deepStrictEqual(dh1.getPrime(), dh3.getPrime());
|
|
assert.deepStrictEqual(dh1.getGenerator(), dh3.getGenerator());
|
|
assert.deepStrictEqual(dh1.getPublicKey(), dh3.getPublicKey());
|
|
assert.deepStrictEqual(dh1.getPrivateKey(), dh3.getPrivateKey());
|
|
assert.strictEqual(dh3.verifyError, 0);
|
|
|
|
const secret3 = dh3.computeSecret(key2, 'hex', 'base64');
|
|
|
|
assert.strictEqual(secret1, secret3);
|
|
|
|
// computeSecret works without a public key set at all.
|
|
const dh4 = crypto.createDiffieHellman(p1, 'buffer');
|
|
dh4.setPrivateKey(privkey1);
|
|
|
|
assert.deepStrictEqual(dh1.getPrime(), dh4.getPrime());
|
|
assert.deepStrictEqual(dh1.getGenerator(), dh4.getGenerator());
|
|
assert.deepStrictEqual(dh1.getPrivateKey(), dh4.getPrivateKey());
|
|
assert.strictEqual(dh4.verifyError, 0);
|
|
|
|
const secret4 = dh4.computeSecret(key2, 'hex', 'base64');
|
|
|
|
assert.strictEqual(secret1, secret4);
|
|
|
|
let wrongBlockLength;
|
|
if (common.hasOpenSSL3) {
|
|
wrongBlockLength = {
|
|
message: 'error:1C80006B:Provider routines::wrong final block length',
|
|
code: 'ERR_OSSL_WRONG_FINAL_BLOCK_LENGTH',
|
|
library: 'Provider routines',
|
|
reason: 'wrong final block length'
|
|
};
|
|
} else {
|
|
wrongBlockLength = {
|
|
message: 'error:0606506D:digital envelope' +
|
|
' routines:EVP_DecryptFinal_ex:wrong final block length',
|
|
code: 'ERR_OSSL_EVP_WRONG_FINAL_BLOCK_LENGTH',
|
|
library: 'digital envelope routines',
|
|
reason: 'wrong final block length'
|
|
};
|
|
}
|
|
|
|
// Run this one twice to make sure that the dh3 clears its error properly
|
|
{
|
|
const c = crypto.createDecipheriv('aes-128-ecb', crypto.randomBytes(16), '');
|
|
assert.throws(() => {
|
|
c.final('utf8');
|
|
}, wrongBlockLength);
|
|
}
|
|
|
|
{
|
|
const c = crypto.createDecipheriv('aes-128-ecb', crypto.randomBytes(16), '');
|
|
assert.throws(() => {
|
|
c.final('utf8');
|
|
}, wrongBlockLength);
|
|
}
|
|
|
|
{
|
|
// Error message was changed in OpenSSL 3.0.x from 3.0.12, and 3.1.x from 3.1.4.
|
|
const hasOpenSSL3WithNewErrorMessage = (common.hasOpenSSL(3, 0, 12) && !common.hasOpenSSL(3, 1, 0)) ||
|
|
(common.hasOpenSSL(3, 1, 4));
|
|
assert.throws(() => {
|
|
dh3.computeSecret('');
|
|
}, { message: common.hasOpenSSL3 && !hasOpenSSL3WithNewErrorMessage ?
|
|
'error:02800080:Diffie-Hellman routines::invalid secret' :
|
|
'Supplied key is too small' });
|
|
}
|
|
}
|
|
|
|
// Through a fluke of history, g=0 defaults to DH_GENERATOR (2).
|
|
{
|
|
const g = 0;
|
|
crypto.createDiffieHellman('abcdef', g);
|
|
crypto.createDiffieHellman('abcdef', 'hex', g);
|
|
}
|
|
|
|
{
|
|
crypto.createDiffieHellman('abcdef', Buffer.from([2])); // OK
|
|
}
|