mirror of
https://github.com/nodejs/node.git
synced 2025-08-15 13:48:44 +02:00
a509753a8e
There are no guarantees that the JS stack can be generated when no
context is entered.
PR-URL: https://github.com/nodejs/node/pull/48495
Fixes: https://github.com/nodejs/node-v8/issues/250
Refs: 4582948
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
53 lines
1.5 KiB
JavaScript
53 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const helper = require('../../common/report.js');
|
|
const tmpdir = require('../../common/tmpdir');
|
|
|
|
const binding = path.resolve(__dirname, `./build/${common.buildType}/binding`);
|
|
const addon = require(binding);
|
|
|
|
function myAddonMain(method, { hasContext, hasEnv }) {
|
|
tmpdir.refresh();
|
|
process.report.directory = tmpdir.path;
|
|
|
|
addon[method]();
|
|
|
|
const reports = helper.findReports(process.pid, tmpdir.path);
|
|
assert.strictEqual(reports.length, 1);
|
|
|
|
const report = reports[0];
|
|
helper.validate(report, [
|
|
['header.event', 'FooMessage'],
|
|
['header.trigger', 'BarTrigger'],
|
|
]);
|
|
|
|
const content = require(report);
|
|
|
|
// Check that the javascript stack is present.
|
|
if (hasContext) {
|
|
assert.strictEqual(content.javascriptStack.stack.findIndex((frame) => frame.match('myAddonMain')), 0);
|
|
} else {
|
|
assert.strictEqual(content.javascriptStack.message, 'No stack.');
|
|
}
|
|
|
|
if (hasEnv) {
|
|
assert.strictEqual(content.header.threadId, 0);
|
|
} else {
|
|
assert.strictEqual(content.header.threadId, null);
|
|
}
|
|
}
|
|
|
|
const methods = [
|
|
['triggerReport', true, true],
|
|
['triggerReportNoIsolate', false, false],
|
|
['triggerReportEnv', true, true],
|
|
['triggerReportNoEnv', false, false],
|
|
['triggerReportNoContext', false, false],
|
|
['triggerReportNewContext', true, false],
|
|
];
|
|
for (const [method, hasContext, hasEnv] of methods) {
|
|
myAddonMain(method, { hasContext, hasEnv });
|
|
}
|