mirror of
https://github.com/nodejs/node.git
synced 2025-08-15 13:48:44 +02:00
cc856b3d5d
When a module is being statically linked with module requests, if two module requests with a same specifier but different attributes are resolved to two modules, the module requests should be linked to these two modules. PR-URL: https://github.com/nodejs/node/pull/58886 Refs: https://tc39.es/ecma262/#sec-HostLoadImportedModule Refs: https://github.com/tc39/proposal-import-attributes?tab=readme-ov-file#how-would-this-proposal-work-with-caching Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
59 lines
2.2 KiB
JavaScript
59 lines
2.2 KiB
JavaScript
import '../common/index.mjs';
|
|
import assert from 'node:assert';
|
|
import Module from 'node:module';
|
|
|
|
// This test verifies that importing two modules with different import
|
|
// attributes should result in different module instances, if the module loader
|
|
// resolves to module instances.
|
|
//
|
|
// For example,
|
|
// ```mjs
|
|
// import * as secret1 from '../primitive-42.json' with { type: 'json' };
|
|
// import * as secret2 from '../primitive-42.json';
|
|
// ```
|
|
// should result in two different module instances, if the second import
|
|
// is been evaluated as a CommonJS module.
|
|
//
|
|
// ECMA-262 requires that in `HostLoadImportedModule`, if the operation is called
|
|
// multiple times with two (referrer, moduleRequest) pairs, it should return the same
|
|
// result. But if the moduleRequest is different, it should return a different,
|
|
// and the module loader resolves to different module instances, it should return
|
|
// different module instances.
|
|
// Refs: https://tc39.es/ecma262/#sec-HostLoadImportedModule
|
|
|
|
const kJsonModuleSpecifier = '../primitive-42.json';
|
|
const fixtureUrl = new URL('../fixtures/primitive-42.json', import.meta.url).href;
|
|
|
|
Module.registerHooks({
|
|
resolve: (specifier, context, nextResolve) => {
|
|
if (kJsonModuleSpecifier !== specifier) {
|
|
return nextResolve(specifier, context);
|
|
}
|
|
if (context.importAttributes.type === 'json') {
|
|
return {
|
|
url: fixtureUrl,
|
|
// Return a new importAttributes object to ensure
|
|
// that the module loader treats this as a same module request.
|
|
importAttributes: {
|
|
type: 'json',
|
|
},
|
|
shortCircuit: true,
|
|
format: 'json',
|
|
};
|
|
}
|
|
return {
|
|
url: fixtureUrl,
|
|
// Return a new importAttributes object to ensure
|
|
// that the module loader treats this as a same module request.
|
|
importAttributes: {},
|
|
shortCircuit: true,
|
|
format: 'module',
|
|
};
|
|
},
|
|
});
|
|
|
|
const { secretModule, secretJson, secretJson2 } = await import('../fixtures/es-modules/json-modules-attributes.mjs');
|
|
assert.notStrictEqual(secretModule, secretJson);
|
|
assert.strictEqual(secretJson, secretJson2);
|
|
assert.strictEqual(secretJson.default, 42);
|
|
assert.strictEqual(secretModule.default, undefined);
|