archive/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-08-15 13:48:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
node/test/fixtures/import-require-cycle
History
Exact
Joyee Cheung 8c17ceb38f
module: allow cycles in require() in the CJS handling in ESM loader 
When --import is used, the ESM loader is used to handle even pure
CJS entry points, and it can run into CJS module facades in the
evaluating state when the parent CJS module is being evaluated.
In this case it should be allowed, since the ESM <-> CJS cycles
that are meant to be disallowed (for the time being) should
already be detected before evaluation and wouldn't get here,
and CJS <-> CJS cycles are fine.

PR-URL: https://github.com/nodejs/node/pull/58598
Fixes: https://github.com/nodejs/node/issues/58515
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2025-06-11 09:33:16 +00:00
..
a.js module: allow cycles in require() in the CJS handling in ESM loader 2025-06-11 09:33:16 +00:00
b.js module: allow cycles in require() in the CJS handling in ESM loader 2025-06-11 09:33:16 +00:00
c.js module: allow cycles in require() in the CJS handling in ESM loader 2025-06-11 09:33:16 +00:00
preload.mjs module: allow cycles in require() in the CJS handling in ESM loader 2025-06-11 09:33:16 +00:00