mirror of
https://github.com/nodejs/node.git
synced 2025-08-15 13:48:44 +02:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
66 lines
2.2 KiB
JavaScript
66 lines
2.2 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
assert.strictEqual(typeof process.umask(), 'number');
|
|
assert.throws(() => {
|
|
process.umask('0664');
|
|
}, { code: 'ERR_WORKER_UNSUPPORTED_OPERATION' });
|
|
|
|
common.skip('Setting process.umask is not supported in Workers');
|
|
}
|
|
|
|
// Note in Windows one can only set the "user" bits.
|
|
let mask;
|
|
if (common.isWindows) {
|
|
mask = '0600';
|
|
} else {
|
|
mask = '0664';
|
|
}
|
|
|
|
const old = process.umask(mask);
|
|
|
|
assert.strictEqual(process.umask(old), parseInt(mask, 8));
|
|
|
|
// Confirm reading the umask does not modify it.
|
|
// 1. If the test fails, this call will succeed, but the mask will be set to 0
|
|
assert.strictEqual(process.umask(), old);
|
|
// 2. If the test fails, process.umask() will return 0
|
|
assert.strictEqual(process.umask(), old);
|
|
|
|
assert.throws(() => {
|
|
process.umask({});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
});
|
|
|
|
['123x', 'abc', '999'].forEach((value) => {
|
|
assert.throws(() => {
|
|
process.umask(value);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
});
|
|
});
|