mirror of
https://github.com/nodejs/node.git
synced 2025-08-15 13:48:44 +02:00
c08a1d152b
This fixes the v8.getHeapSnapshot() calls not properly being destroyed. Pipeline calls would for example not properly end without the callback being in place. PR-URL: https://github.com/nodejs/node/pull/58846 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
91 lines
2.2 KiB
JavaScript
91 lines
2.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('process.chdir is not available in Workers');
|
|
}
|
|
|
|
const { writeHeapSnapshot, getHeapSnapshot } = require('v8');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const { promises: { pipeline }, PassThrough } = require('stream');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
tmpdir.refresh();
|
|
process.chdir(tmpdir.path);
|
|
|
|
{
|
|
writeHeapSnapshot('my.heapdump');
|
|
fs.accessSync('my.heapdump');
|
|
}
|
|
|
|
{
|
|
const heapdump = writeHeapSnapshot();
|
|
assert.strictEqual(typeof heapdump, 'string');
|
|
fs.accessSync(heapdump);
|
|
}
|
|
|
|
{
|
|
const directory = 'directory';
|
|
fs.mkdirSync(directory);
|
|
assert.throws(() => {
|
|
writeHeapSnapshot(directory);
|
|
}, (e) => {
|
|
assert.ok(e, 'writeHeapSnapshot should error');
|
|
assert.strictEqual(e.code, 'EISDIR');
|
|
assert.strictEqual(e.syscall, 'open');
|
|
return true;
|
|
});
|
|
}
|
|
|
|
[1, true, {}, [], null, Infinity, NaN].forEach((i) => {
|
|
assert.throws(() => writeHeapSnapshot(i), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "path" argument must be of type string or an instance of ' +
|
|
'Buffer or URL.' +
|
|
common.invalidArgTypeHelper(i)
|
|
});
|
|
});
|
|
|
|
[1, true, [], null, Infinity, NaN].forEach((i) => {
|
|
assert.throws(() => writeHeapSnapshot('test.heapsnapshot', i), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "options" argument must be of type object.' +
|
|
common.invalidArgTypeHelper(i)
|
|
});
|
|
});
|
|
|
|
[1, true, [], null, Infinity, NaN].forEach((i) => {
|
|
assert.throws(() => getHeapSnapshot(i), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "options" argument must be of type object.' +
|
|
common.invalidArgTypeHelper(i)
|
|
});
|
|
});
|
|
|
|
{
|
|
let data = '';
|
|
const snapshot = getHeapSnapshot();
|
|
snapshot.setEncoding('utf-8');
|
|
snapshot.on('data', common.mustCallAtLeast((chunk) => {
|
|
data += chunk.toString();
|
|
}));
|
|
snapshot.on('end', common.mustCall(() => {
|
|
JSON.parse(data);
|
|
}));
|
|
}
|
|
|
|
{
|
|
const passthrough = new PassThrough();
|
|
passthrough.on('data', common.mustCallAtLeast(1));
|
|
|
|
pipeline(
|
|
getHeapSnapshot(),
|
|
passthrough,
|
|
).then(common.mustCall());
|
|
}
|