mirror of
https://github.com/nodejs/node.git
synced 2025-08-15 21:58:48 +02:00
0babd181a0
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
106 lines
2.6 KiB
JavaScript
106 lines
2.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const {
|
|
constants,
|
|
Http2Session,
|
|
nghttp2ErrorString
|
|
} = process.binding('http2');
|
|
const http2 = require('http2');
|
|
|
|
// tests error handling within requestOnConnect
|
|
// - NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE (should emit session error)
|
|
// - NGHTTP2_ERR_INVALID_ARGUMENT (should emit stream error)
|
|
// - every other NGHTTP2 error from binding (should emit session error)
|
|
|
|
const specificTestKeys = [
|
|
'NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE',
|
|
'NGHTTP2_ERR_INVALID_ARGUMENT'
|
|
];
|
|
|
|
const specificTests = [
|
|
{
|
|
ngError: constants.NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE,
|
|
error: {
|
|
code: 'ERR_HTTP2_OUT_OF_STREAMS',
|
|
type: Error,
|
|
message: 'No stream ID is available because ' +
|
|
'maximum stream ID has been reached'
|
|
},
|
|
type: 'stream'
|
|
},
|
|
{
|
|
ngError: constants.NGHTTP2_ERR_INVALID_ARGUMENT,
|
|
error: {
|
|
code: 'ERR_HTTP2_STREAM_SELF_DEPENDENCY',
|
|
type: Error,
|
|
message: 'A stream cannot depend on itself'
|
|
},
|
|
type: 'stream'
|
|
},
|
|
];
|
|
|
|
const genericTests = Object.getOwnPropertyNames(constants)
|
|
.filter((key) => (
|
|
key.indexOf('NGHTTP2_ERR') === 0 && specificTestKeys.indexOf(key) < 0
|
|
))
|
|
.map((key) => ({
|
|
ngError: constants[key],
|
|
error: {
|
|
code: 'ERR_HTTP2_ERROR',
|
|
type: Error,
|
|
message: nghttp2ErrorString(constants[key])
|
|
},
|
|
type: 'session'
|
|
}));
|
|
|
|
const tests = specificTests.concat(genericTests);
|
|
|
|
let currentError;
|
|
|
|
// mock submitRequest because we only care about testing error handling
|
|
Http2Session.prototype.request = () => currentError;
|
|
|
|
const server = http2.createServer(common.mustNotCall());
|
|
|
|
server.listen(0, common.mustCall(() => runTest(tests.shift())));
|
|
|
|
function runTest(test) {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
client.on('close', common.mustCall());
|
|
|
|
const req = client.request({ ':method': 'POST' });
|
|
|
|
currentError = test.ngError;
|
|
req.resume();
|
|
req.end();
|
|
|
|
const errorMustCall = common.expectsError(test.error);
|
|
const errorMustNotCall = common.mustNotCall(
|
|
`${test.error.code} should emit on ${test.type}`
|
|
);
|
|
|
|
if (test.type === 'stream') {
|
|
client.on('error', errorMustNotCall);
|
|
req.on('error', errorMustCall);
|
|
} else {
|
|
client.on('error', errorMustCall);
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_CANCEL'
|
|
}));
|
|
}
|
|
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => {
|
|
client.destroy();
|
|
|
|
if (!tests.length) {
|
|
server.close();
|
|
} else {
|
|
runTest(tests.shift());
|
|
}
|
|
}));
|
|
}
|