diff --git a/ext/dom/document.c b/ext/dom/document.c index 173a4e351b8..7162550015d 100644 --- a/ext/dom/document.c +++ b/ext/dom/document.c @@ -1285,7 +1285,7 @@ PHP_METHOD(DOMDocument, __construct) } /* }}} end DOMDocument::__construct */ -const char *_dom_get_valid_file_path(const char *source, char *resolved_path, int resolved_path_len ) /* {{{ */ +const char *dom_get_valid_file_path(const char *source, char *resolved_path, int resolved_path_len ) /* {{{ */ { xmlURI *uri; xmlChar *escsource; @@ -1372,7 +1372,7 @@ xmlDocPtr dom_document_parser(zval *id, dom_load_mode mode, const char *source, zend_argument_value_error(1, "must not contain any null bytes"); return NULL; } - const char *file_dest = _dom_get_valid_file_path(source, resolved_path, MAXPATHLEN); + const char *file_dest = dom_get_valid_file_path(source, resolved_path, MAXPATHLEN); if (file_dest) { ctxt = xmlCreateFileParserCtxt(file_dest); } @@ -1853,7 +1853,7 @@ PHP_METHOD(DOMDocument, validate) /* }}} */ #ifdef LIBXML_SCHEMAS_ENABLED -static void _dom_document_schema_validate(INTERNAL_FUNCTION_PARAMETERS, int type) /* {{{ */ +static void dom_document_schema_validate(INTERNAL_FUNCTION_PARAMETERS, int type) /* {{{ */ { zval *id; xmlDoc *docp; @@ -1890,7 +1890,7 @@ static void _dom_document_schema_validate(INTERNAL_FUNCTION_PARAMETERS, int type zend_argument_value_error(1, "must not contain any null bytes"); RETURN_THROWS(); } - valid_file = _dom_get_valid_file_path(source, resolved_path, MAXPATHLEN); + valid_file = dom_get_valid_file_path(source, resolved_path, MAXPATHLEN); if (!valid_file) { PHP_LIBXML_RESTORE_GLOBALS(new_parser_ctxt); php_error_docref(NULL, E_WARNING, "Invalid Schema file source"); @@ -1953,18 +1953,18 @@ static void _dom_document_schema_validate(INTERNAL_FUNCTION_PARAMETERS, int type /* {{{ */ PHP_METHOD(DOMDocument, schemaValidate) { - _dom_document_schema_validate(INTERNAL_FUNCTION_PARAM_PASSTHRU, DOM_LOAD_FILE); + dom_document_schema_validate(INTERNAL_FUNCTION_PARAM_PASSTHRU, DOM_LOAD_FILE); } /* }}} end dom_document_schema_validate_file */ /* {{{ */ PHP_METHOD(DOMDocument, schemaValidateSource) { - _dom_document_schema_validate(INTERNAL_FUNCTION_PARAM_PASSTHRU, DOM_LOAD_STRING); + dom_document_schema_validate(INTERNAL_FUNCTION_PARAM_PASSTHRU, DOM_LOAD_STRING); } /* }}} end dom_document_schema_validate */ -static void _dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAMETERS, int type) /* {{{ */ +static void dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAMETERS, int type) /* {{{ */ { zval *id; xmlDoc *docp; @@ -1996,7 +1996,7 @@ static void _dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAMETERS, int typ zend_argument_value_error(1, "must not contain any null bytes"); RETURN_THROWS(); } - valid_file = _dom_get_valid_file_path(source, resolved_path, MAXPATHLEN); + valid_file = dom_get_valid_file_path(source, resolved_path, MAXPATHLEN); if (!valid_file) { php_error_docref(NULL, E_WARNING, "Invalid RelaxNG file source"); RETURN_FALSE; @@ -2050,14 +2050,14 @@ static void _dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAMETERS, int typ /* {{{ */ PHP_METHOD(DOMDocument, relaxNGValidate) { - _dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAM_PASSTHRU, DOM_LOAD_FILE); + dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAM_PASSTHRU, DOM_LOAD_FILE); } /* }}} end dom_document_relaxNG_validate_file */ /* {{{ */ PHP_METHOD(DOMDocument, relaxNGValidateSource) { - _dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAM_PASSTHRU, DOM_LOAD_STRING); + dom_document_relaxNG_validate(INTERNAL_FUNCTION_PARAM_PASSTHRU, DOM_LOAD_STRING); } /* }}} end dom_document_relaxNG_validate_xml */ diff --git a/ext/dom/element.c b/ext/dom/element.c index 9bd762a9b9e..9795c0bd7aa 100644 --- a/ext/dom/element.c +++ b/ext/dom/element.c @@ -476,7 +476,7 @@ PHP_METHOD(DOMElement, setAttribute) } /* }}} end dom_element_set_attribute */ -typedef struct _dom_deep_ns_redef_item { +typedef struct dom_deep_ns_redef_item { xmlNodePtr current_node; xmlNsPtr defined_ns; } dom_deep_ns_redef_item; diff --git a/ext/dom/html5_parser.c b/ext/dom/html5_parser.c index b4c3eadfdf8..66c490b1d16 100644 --- a/ext/dom/html5_parser.c +++ b/ext/dom/html5_parser.c @@ -33,7 +33,7 @@ /* libxml2 reserves 2 pointer-sized words for interned strings */ #define LXML_INTERNED_STRINGS_SIZE (sizeof(void *) * 2) -typedef struct _work_list_item { +typedef struct work_list_item { lxb_dom_node_t *node; uintptr_t current_active_namespace; xmlNodePtr lxml_parent; diff --git a/ext/dom/html5_parser.h b/ext/dom/html5_parser.h index 86b4b106b97..bfa6223f6a5 100644 --- a/ext/dom/html5_parser.h +++ b/ext/dom/html5_parser.h @@ -43,14 +43,14 @@ typedef void (*lexbor_libxml2_bridge_tree_error_reporter)( size_t len ); -typedef struct _lexbor_libxml2_bridge_extracted_observations { +typedef struct lexbor_libxml2_bridge_extracted_observations { bool has_explicit_html_tag; bool has_explicit_head_tag; bool has_explicit_body_tag; php_libxml_quirks_mode quirks_mode; } lexbor_libxml2_bridge_extracted_observations; -typedef struct _lexbor_libxml2_bridge_parse_context { +typedef struct lexbor_libxml2_bridge_parse_context { /* Private fields */ lexbor_libxml2_bridge_tokenizer_error_reporter tokenizer_error_reporter; lexbor_libxml2_bridge_tree_error_reporter tree_error_reporter; diff --git a/ext/dom/html_collection.c b/ext/dom/html_collection.c index fbe5aba65ee..4bc5713d37c 100644 --- a/ext/dom/html_collection.c +++ b/ext/dom/html_collection.c @@ -25,7 +25,7 @@ #include "html_collection.h" #include "namespace_compat.h" -typedef struct _dom_named_item { +typedef struct dom_named_item { dom_object *context_intern; xmlNodePtr node; } dom_named_item; diff --git a/ext/dom/namespace_compat.c b/ext/dom/namespace_compat.c index 22442effa86..fece1f59ac9 100644 --- a/ext/dom/namespace_compat.c +++ b/ext/dom/namespace_compat.c @@ -30,7 +30,7 @@ PHP_DOM_EXPORT const php_dom_ns_magic_token *php_dom_ns_is_xlink_magic_token = ( PHP_DOM_EXPORT const php_dom_ns_magic_token *php_dom_ns_is_xml_magic_token = (const php_dom_ns_magic_token *) DOM_XML_NS_URI; PHP_DOM_EXPORT const php_dom_ns_magic_token *php_dom_ns_is_xmlns_magic_token = (const php_dom_ns_magic_token *) DOM_XMLNS_NS_URI; -struct _php_dom_libxml_ns_mapper { +struct php_dom_libxml_ns_mapper { php_libxml_private_data_header header; /* This is used almost all the time for HTML documents, so it makes sense to cache this. */ xmlNsPtr html_ns; diff --git a/ext/dom/namespace_compat.h b/ext/dom/namespace_compat.h index 1016bf1e5ee..bf0a295e1be 100644 --- a/ext/dom/namespace_compat.h +++ b/ext/dom/namespace_compat.h @@ -30,8 +30,8 @@ struct php_dom_ns_magic_token; typedef struct php_dom_ns_magic_token php_dom_ns_magic_token; -struct _php_dom_libxml_ns_mapper; -typedef struct _php_dom_libxml_ns_mapper php_dom_libxml_ns_mapper; +struct php_dom_libxml_ns_mapper; +typedef struct php_dom_libxml_ns_mapper php_dom_libxml_ns_mapper; PHP_DOM_EXPORT extern const php_dom_ns_magic_token *php_dom_ns_is_html_magic_token; PHP_DOM_EXPORT extern const php_dom_ns_magic_token *php_dom_ns_is_mathml_magic_token; @@ -40,8 +40,8 @@ PHP_DOM_EXPORT extern const php_dom_ns_magic_token *php_dom_ns_is_xlink_magic_to PHP_DOM_EXPORT extern const php_dom_ns_magic_token *php_dom_ns_is_xml_magic_token; PHP_DOM_EXPORT extern const php_dom_ns_magic_token *php_dom_ns_is_xmlns_magic_token; -typedef struct _php_libxml_private_data_header php_libxml_private_data_header; -struct _php_libxml_private_data_header; +typedef struct php_libxml_private_data_header php_libxml_private_data_header; +struct php_libxml_private_data_header; /* These functions make it possible to make a namespace declaration also visible as an attribute by * creating an equivalent attribute node. */ @@ -64,7 +64,7 @@ PHP_DOM_EXPORT bool php_dom_ns_is_fast(const xmlNode *nodep, const php_dom_ns_ma PHP_DOM_EXPORT bool php_dom_ns_is_fast_ex(xmlNsPtr ns, const php_dom_ns_magic_token *magic_token); PHP_DOM_EXPORT bool php_dom_ns_is_html_and_document_is_html(const xmlNode *nodep); -typedef struct _php_dom_in_scope_ns { +typedef struct php_dom_in_scope_ns { xmlNsPtr *list; size_t count; bool origin_is_ns_compat; diff --git a/ext/dom/php_dom.c b/ext/dom/php_dom.c index 1fdeaf514d5..e6e7a23600d 100644 --- a/ext/dom/php_dom.c +++ b/ext/dom/php_dom.c @@ -149,7 +149,7 @@ static xmlNodePtr php_dom_create_fake_namespace_decl_node_ptr(xmlNodePtr nodep, typedef zend_result (*dom_read_t)(dom_object *obj, zval *retval); typedef zend_result (*dom_write_t)(dom_object *obj, zval *newval); -typedef struct _dom_prop_handler { +typedef struct dom_prop_handler { dom_read_t read_func; dom_write_t write_func; } dom_prop_handler; diff --git a/ext/dom/php_dom.h b/ext/dom/php_dom.h index c4f416914c3..aa1f3316c20 100644 --- a/ext/dom/php_dom.h +++ b/ext/dom/php_dom.h @@ -64,7 +64,7 @@ extern zend_module_entry dom_module_entry; /* Define a custom type for iterating using an unused nodetype */ #define DOM_NODESET XML_XINCLUDE_START -typedef struct _dom_xpath_object { +typedef struct dom_xpath_object { php_dom_xpath_callbacks xpath_callbacks; bool register_node_ns; dom_object dom; @@ -77,7 +77,7 @@ static inline dom_xpath_object *php_xpath_obj_from_obj(zend_object *obj) { #define Z_XPATHOBJ_P(zv) php_xpath_obj_from_obj(Z_OBJ_P((zv))) -typedef struct _dom_nnodemap_object { +typedef struct dom_nnodemap_object { dom_object *baseobj; zval baseobj_zv; int nodetype; @@ -107,7 +107,7 @@ typedef struct { dom_object dom; } dom_object_namespace_node; -typedef enum _dom_iterator_type { +typedef enum dom_iterator_type { DOM_NODELIST, DOM_NAMEDNODEMAP, DOM_DTD_NAMEDNODEMAP, diff --git a/ext/dom/xml_common.h b/ext/dom/xml_common.h index ec555f3d0f1..94c753132b8 100644 --- a/ext/dom/xml_common.h +++ b/ext/dom/xml_common.h @@ -80,8 +80,8 @@ PHP_DOM_EXPORT xmlNodePtr dom_object_get_node(dom_object *obj); __id = ZEND_THIS; \ DOM_GET_OBJ(__ptr, __id, __prtype, __intern); -struct _php_dom_libxml_ns_mapper; -typedef struct _php_dom_libxml_ns_mapper php_dom_libxml_ns_mapper; +struct php_dom_libxml_ns_mapper; +typedef struct php_dom_libxml_ns_mapper php_dom_libxml_ns_mapper; static zend_always_inline php_dom_libxml_ns_mapper *php_dom_get_ns_mapper(dom_object *intern) { diff --git a/ext/libxml/php_libxml.h b/ext/libxml/php_libxml.h index 4af92125ed7..95f2cd42d82 100644 --- a/ext/libxml/php_libxml.h +++ b/ext/libxml/php_libxml.h @@ -65,8 +65,8 @@ typedef struct { size_t modification_nr; } php_libxml_cache_tag; -typedef struct _php_libxml_private_data_header { - void (*dtor)(struct _php_libxml_private_data_header *); +typedef struct php_libxml_private_data_header { + void (*dtor)(struct php_libxml_private_data_header *); /* extra fields */ } php_libxml_private_data_header;