archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-15 13:38:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid unnecessary string refcounting in ext/pcre (#17893)

Browse source
This commit is contained in:
Niels Dossche 2025-02-23 00:23:39 +01:00 • committed by GitHub
parent 1eacd4aea0
commit 03f97fc34b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
ext/pcre/php_pcre.c
View file

@ -1563,9 +1563,12 @@ static zend_string *preg_do_repl_func(zend_fcall_info *fci, zend_fcall_info_cach
fci->params = &arg; fci->params = &arg;
zend_call_function(fci, fcc); zend_call_function(fci, fcc);
zval_ptr_dtor(&arg); zval_ptr_dtor(&arg);
if (EXPECTED(Z_TYPE(retval) == IS_STRING)) {
return Z_STR(retval);
}
/* No Exception has occurred */ /* No Exception has occurred */
if (EXPECTED(Z_TYPE(retval) != IS_UNDEF)) { else if (EXPECTED(Z_TYPE(retval) != IS_UNDEF)) {
result_str = zval_try_get_string(&retval); result_str = zval_try_get_string_func(&retval);
} }
zval_ptr_dtor(&retval); zval_ptr_dtor(&retval);