archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

don't crash if the API is used incorrectly

Browse source
This commit is contained in:
Andrey Hristov 2010-12-06 13:50:51 +00:00
parent 75eeee8f24
commit 03fd10c479
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ext/mysqlnd/mysqlnd.c
View file

@ -1971,15 +1971,19 @@ MYSQLND_METHOD(mysqlnd_conn, change_user)(MYSQLND * const conn,
} }
} }
if (ret == PASS) { if (ret == PASS) {
char * tmp = NULL;
/* if we get conn->user as parameter and then we first free it, then estrndup it, we will crash */
tmp = mnd_pestrndup(user, user_len, conn->persistent);
if (conn->user) { if (conn->user) {
mnd_pefree(conn->user, conn->persistent); mnd_pefree(conn->user, conn->persistent);
} }
conn->user = mnd_pestrndup(user, user_len, conn->persistent); conn->user = tmp;
tmp = mnd_pestrdup(passwd, conn->persistent);
if (conn->passwd) { if (conn->passwd) {
mnd_pefree(conn->passwd, conn->persistent); mnd_pefree(conn->passwd, conn->persistent);
} }
conn->passwd = mnd_pestrdup(passwd, conn->persistent); conn->passwd = tmp;
if (conn->last_message) { if (conn->last_message) {
mnd_pefree(conn->last_message, conn->persistent); mnd_pefree(conn->last_message, conn->persistent);