archive/php-src
1
0
Fork 0
mirror of https://github.com/php/php-src.git synced 2025-08-16 05:58:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid K&R style function declarations in sha1()

Browse source 
These are deprecated in C20.
This commit is contained in:
Nikita Popov 2022-07-28 22:17:21 +02:00
parent 6ff662b2e6
commit 04f5da4b77
1 changed files with 3 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
ext/standard/sha1.c
View file

@ -247,9 +247,7 @@ PHPAPI void PHP_SHA1Final(unsigned char digest[20], PHP_SHA1_CTX * context)
/* {{{ SHA1Transform /* {{{ SHA1Transform
* SHA1 basic transformation. Transforms state based on block. * SHA1 basic transformation. Transforms state based on block.
*/ */
static void SHA1Transform(state, block) static void SHA1Transform(uint32_t state[5], const unsigned char block[64])
uint32_t state[5];
const unsigned char block[64];
{ {
uint32_t a = state[0], b = state[1], c = state[2]; uint32_t a = state[0], b = state[1], c = state[2];
uint32_t d = state[3], e = state[4], x[16], tmp; uint32_t d = state[3], e = state[4], x[16], tmp;
@ -359,10 +357,7 @@ const unsigned char block[64];
Encodes input (uint32_t) into output (unsigned char). Assumes len is Encodes input (uint32_t) into output (unsigned char). Assumes len is
a multiple of 4. a multiple of 4.
*/ */
static void SHA1Encode(output, input, len) static void SHA1Encode(unsigned char *output, uint32_t *input, unsigned int len)
unsigned char *output;
uint32_t *input;
unsigned int len;
{ {
unsigned int i, j; unsigned int i, j;
@ -379,10 +374,7 @@ unsigned int len;
Decodes input (unsigned char) into output (uint32_t). Assumes len is Decodes input (unsigned char) into output (uint32_t). Assumes len is
a multiple of 4. a multiple of 4.
*/ */
static void SHA1Decode(output, input, len) static void SHA1Decode(uint32_t *output, const unsigned char *input, unsigned int len)
uint32_t *output;
const unsigned char *input;
unsigned int len;
{ {
unsigned int i, j; unsigned int i, j;